From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:34342)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RvY5e-0006cW-Pv
	for qemu-devel@nongnu.org; Thu, 09 Feb 2012 12:47:35 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RvY5a-0002W7-6Z
	for qemu-devel@nongnu.org; Thu, 09 Feb 2012 12:47:26 -0500
Received: from mail-pw0-f45.google.com ([209.85.160.45]:50291)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RvY5a-0002Vs-20
	for qemu-devel@nongnu.org; Thu, 09 Feb 2012 12:47:22 -0500
Received: by pbbro12 with SMTP id ro12so1953683pbb.4
	for <qemu-devel@nongnu.org>; Thu, 09 Feb 2012 09:47:20 -0800 (PST)
Message-ID: <4F3406A4.5020800@codemonkey.ws>
Date: Thu, 09 Feb 2012 11:47:16 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1328797255-18410-1-git-send-email-afaerber@suse.de>
	<CAFEAcA__5XKkG_dR+1-S77cCnLsG0cpD69AU4LvpQ2LjrS+LKQ@mail.gmail.com>
In-Reply-To: <CAFEAcA__5XKkG_dR+1-S77cCnLsG0cpD69AU4LvpQ2LjrS+LKQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH v2] qom: Unify type registration
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>, qemu-devel@nongnu.org

On 02/09/2012 10:49 AM, Peter Maydell wrote:
> On 9 February 2012 14:20, Andreas Färber<afaerber@suse.de>  wrote:
>> Replace device_init() with generalized type_init().
>>
>> While at it, unify naming convention: type_init([$prefix_]register_types)
>> Also, type_init() is a function, so add preceding blank line where
>> necessary and don't put a semicolon after the closing brace.
>
> Ugh, touching the whole tree again?

Yeah, it's not coming from me at least :-)

I doubt this will cause any rebase problems though.

Regards,

Anthony Liguori

>
> -- PMM
>