From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:43953) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RvcQe-0006Ik-6W for qemu-devel@nongnu.org; Thu, 09 Feb 2012 17:25:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RvcQb-000275-Mh for qemu-devel@nongnu.org; Thu, 09 Feb 2012 17:25:24 -0500 Received: from relay1.mentorg.com ([192.94.38.131]:51110) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RvcQa-000269-Ui for qemu-devel@nongnu.org; Thu, 09 Feb 2012 17:25:21 -0500 Message-ID: <4F3447C9.7030800@codesourcery.com> Date: Thu, 9 Feb 2012 16:25:13 -0600 From: Meador Inge MIME-Version: 1.0 References: <1328647446-5452-1-git-send-email-meadori@codesourcery.com> <87liodivvw.fsf@linux.vnet.ibm.com> In-Reply-To: <87liodivvw.fsf@linux.vnet.ibm.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v1 0/1] Allow the building of VirtFS to be disabled List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Aneesh Kumar K.V" Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org On 02/08/2012 02:15 AM, Aneesh Kumar K.V wrote: > On Tue, 7 Feb 2012 14:44:05 -0600, Meador Inge wrote: >> There have been reports [1, 2] where folks have had issues building >> VirtFS and the virtio backend on older systems. I personally saw >> problems due to the use of features (struct statfs f_frsize field, >> fdopendir, O_NOATIME) in this code that are not available on much older >> Linux systems. Given, the system I ran into this on is ancient (RH8 sysroot), >> but I still need to build QEMU on it nonetheless. >> >> This patch adds a new configure option for disabling the building of >> VirtFS all together. Tested by building with and without --disable-virtfs >> on older (RH8 sysroot) and newer systems (x64 Fedora 16). >> >> [1] http://lists.nongnu.org/archive/html/qemu-devel/2011-12/msg00171.html >> [2] http://lists.nongnu.org/archive/html/qemu-devel/2012-02/msg00404.html >> >> Meador Inge (1): >> ./configure: add option for disabling VirtFS >> >> Makefile | 4 ++++ >> configure | 16 +++++++++++++--- >> 2 files changed, 17 insertions(+), 3 deletions(-) > > I like the patch because it help to get qemu build on platforms where > the build failures are only due to virtfs. VirtFS do depend on some of > the recent linux APIs, so sometime we do break build on old Linux > distros. Great. Thanks for the review. Can someone commit this for me? > Anthony any objection here ? > > -aneesh > -- Meador Inge CodeSourcery / Mentor Embedded http://www.mentor.com/embedded-software