From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:34351) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RvhVf-0000ph-UE for qemu-devel@nongnu.org; Thu, 09 Feb 2012 22:51:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RvhVd-0002fC-Ew for qemu-devel@nongnu.org; Thu, 09 Feb 2012 22:50:55 -0500 Received: from mailout3.w1.samsung.com ([210.118.77.13]:9282) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RvhVd-0002f4-3x for qemu-devel@nongnu.org; Thu, 09 Feb 2012 22:50:53 -0500 Received: from euspt1 ([210.118.77.13]) by mailout3.w1.samsung.com (Sun Java(tm) System Messaging Server 6.3-8.04 (built Jul 29 2009; 32bit)) with ESMTP id <0LZ500BIQS0N6V00@mailout3.w1.samsung.com> for qemu-devel@nongnu.org; Fri, 10 Feb 2012 03:50:47 +0000 (GMT) Received: from [106.109.9.191] by spt1.w1.samsung.com (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004)) with ESMTPA id <0LZ500HIZS0MVC@spt1.w1.samsung.com> for qemu-devel@nongnu.org; Fri, 10 Feb 2012 03:50:47 +0000 (GMT) Date: Fri, 10 Feb 2012 07:50:45 +0400 From: Evgeny Voevodin In-reply-to: <1328799563-18932-1-git-send-email-afaerber@suse.de> Message-id: <4F349415.2000507@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=UTF-8; format=flowed Content-transfer-encoding: QUOTED-PRINTABLE References: <1328799563-18932-1-git-send-email-afaerber@suse.de> Subject: Re: [Qemu-devel] [PATCH] checkpatch: Don't WARN about missing spaces in audio files List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Cc: Anthony Liguori , Stefan Hajnoczi , Alexander Graf , qemu-devel@nongnu.org, Blue Swirl , Paolo Bonzini On 02/09/2012 06:59 PM, Andreas F=C3=A4rber wrote: > Disable warnings for spaces before opening parenthesis in > hw/{ac97,adlib,cs4231a,es1370,gus,sb16}.c. Why audio files are such a special thing? Isn't it be better to revert a patch that introduced checkpatch.pl er= rors? --=20 Kind regards, Evgeny Voevodin, Leading Software Engineer, ASWG, Moscow R&D center, Samsung Electronics e-mail: e.voevodin@samsung.com