From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:36029) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RvktR-0000af-0l for qemu-devel@nongnu.org; Fri, 10 Feb 2012 02:27:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RvktP-00051K-JK for qemu-devel@nongnu.org; Fri, 10 Feb 2012 02:27:40 -0500 Received: from fmmailgate02.web.de ([217.72.192.227]:38724) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RvktP-000517-9w for qemu-devel@nongnu.org; Fri, 10 Feb 2012 02:27:39 -0500 Received: from moweb002.kundenserver.de (moweb002.kundenserver.de [172.19.20.108]) by fmmailgate02.web.de (Postfix) with ESMTP id 5453A1C0D197D for ; Fri, 10 Feb 2012 08:27:38 +0100 (CET) Message-ID: <4F34C6E2.8000602@web.de> Date: Fri, 10 Feb 2012 08:27:30 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <1328761361-23119-1-git-send-email-david@gibson.dropbear.id.au> <4F338411.20408@web.de> <20120209095823.GE22832@truffala.fritz.box> <4F339AC1.6080700@web.de> <20120210064339.GH10536@truffala.fritz.box> In-Reply-To: <20120210064339.GH10536@truffala.fritz.box> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig3555078BFCC9F28736EEBF9B" Subject: Re: [Qemu-devel] [PATCH] ioctl() numbers are unsigned (the man page lies) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: mtosatti@redhat.com, avi@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig3555078BFCC9F28736EEBF9B Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2012-02-10 07:43, David Gibson wrote: > On Thu, Feb 09, 2012 at 11:06:57AM +0100, Jan Kiszka wrote: >> On 2012-02-09 10:58, David Gibson wrote: >>> On Thu, Feb 09, 2012 at 09:30:09AM +0100, Jan Kiszka wrote: >>>> Looks like the subject would warmly welcome a "kvm:" tag. >>>> >>>> On 2012-02-09 05:22, David Gibson wrote: >>> [snip] >>>> >>>> What about naming the problem instead: >>>> >>>> /* Comparison with IOCTL macros on 32-bit hosts requires unsigned. *= / >>> >>> Just once, it would be nice to post something to this list and get a >>> substantive comment _before_ the bitching about minutiae. >>> >>> Oh, and it's not just 32-bit hosts, it's anywhere sizeof(int)=3D=3D4,= >>> which includes ppc64 amongst other 64-bit hosts. >> >> Then state "if int is 32 bits". The comment is unfortunately not helpf= ul >> without the commit log. >=20 > It'd also be nice if people didn't drop me from the CC list on my own > patches. Sorry, that was not intentional. My mail client possibly followed a tag like in this mail: Mail-Followup-To: Jan Kiszka , anthony@codemonkey.ws, avi@redhat.com, mtosatti@redhat.com, qemu-devel@nongnu.org I had to add you by hand to the list again. Maybe you wanna check what is causing this on your side. Jan --------------enig3555078BFCC9F28736EEBF9B Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk80xuIACgkQitSsb3rl5xS/FgCeKrCIhFXt8jMArwWZqG4suCMc Mu0AmwcwJpyVtFk9y8qx+8UpvVsWop4r =YuXP -----END PGP SIGNATURE----- --------------enig3555078BFCC9F28736EEBF9B--