From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:35200)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1RvogR-0006op-VV
	for qemu-devel@nongnu.org; Fri, 10 Feb 2012 06:30:37 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1RvogL-0006De-OW
	for qemu-devel@nongnu.org; Fri, 10 Feb 2012 06:30:31 -0500
Received: from mx1.redhat.com ([209.132.183.28]:28313)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1RvogL-0006DW-Ff
	for qemu-devel@nongnu.org; Fri, 10 Feb 2012 06:30:25 -0500
Message-ID: <4F34FFCD.8040603@redhat.com>
Date: Fri, 10 Feb 2012 12:30:21 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1328625520-19217-1-git-send-email-berrange@redhat.com>
In-Reply-To: <1328625520-19217-1-git-send-email-berrange@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2] Add SPICE support to add_client monitor
	command
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>

On 02/07/12 15:38, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange@redhat.com>
> 
> This is a followup to
> 
>   http://patchwork.ozlabs.org/patch/121004/
> 
> With the acceptance of some new APIs to libspice-server.so it
> is possible to add support for SPICE to the 'add_client'
> monitor command, bringing parity with VNC. Since SPICE can
> use TLS or plain connections, the command also gains a new
> 'tls' parameter to specify whether TLS should be attempted
> on the injected client sockets.
> 
> This new feature is only enabled if building against a
> libspice-server >= 0.10.1
> 
> * qmp-commands.hx: Add 'tls' parameter & missing doc for
>   'skipauth' parameter
> * monitor.c: Wire up SPICE for 'add_client' command
> * ui/qemu-spice.h, ui/spice-core.c: Add qemu_spice_display_add_client
>   API to wire up from monitor

Spice bits are sane, the monitor bits look good to me too.

Luiz?  Can you have a look at the monitor bits?  If you ack I'll go
queue it up for the next spice update.  Or you can just grab it and
merge via qmp tree.

cheers,
  Gerd