From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:44139) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RvrL6-0002Nr-6q for qemu-devel@nongnu.org; Fri, 10 Feb 2012 09:20:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RvrL4-0005L6-TD for qemu-devel@nongnu.org; Fri, 10 Feb 2012 09:20:40 -0500 Received: from mail-pw0-f45.google.com ([209.85.160.45]:44550) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RvrL4-0005Kq-MC for qemu-devel@nongnu.org; Fri, 10 Feb 2012 09:20:38 -0500 Received: by pbbro12 with SMTP id ro12so2794700pbb.4 for ; Fri, 10 Feb 2012 06:20:37 -0800 (PST) Sender: Paolo Bonzini Message-ID: <4F3527AF.70406@redhat.com> Date: Fri, 10 Feb 2012 15:20:31 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1328722656-22856-1-git-send-email-pbonzini@redhat.com> <1328722656-22856-6-git-send-email-pbonzini@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 5/5] raw-posix: unmount CD-ROM filesystem via udisks List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: amit.shah@redhat.com, qemu-devel@nongnu.org On 02/10/2012 01:51 PM, Markus Armbruster wrote: > > We need to use O_EXCL in order to suppress event generation in the > > kernel. However, O_EXCL by definition fails when the CD-ROM drive > > is mounted. Automatically unmount it when it is passed through to > > the guest. > > I'm not sure automatic unmount is worth the trouble, and I'm even less > sure making the auto-unmount mandatory is a smart move. Getting O_EXCL access is worth the trouble. Everything else is just means to an end. :) Paolo