qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <aliguori@us.ibm.com>
To: malc <av1474@comtv.ru>
Cc: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
	Evgeny Voevodin <e.voevodin@samsung.com>,
	Alexander Graf <agraf@suse.de>,
	qemu-devel@nongnu.org, Blue Swirl <blauwirbel@gmail.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] checkpatch: Don't WARN about missing spaces in audio files
Date: Fri, 10 Feb 2012 11:47:49 -0600	[thread overview]
Message-ID: <4F355845.5040902@us.ibm.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1202100801170.4898@linmac>

On 02/09/2012 10:02 PM, malc wrote:
> On Fri, 10 Feb 2012, Evgeny Voevodin wrote:
>
>> On 02/09/2012 06:59 PM, Andreas F?rber wrote:
>>> Disable warnings for spaces before opening parenthesis in
>>> hw/{ac97,adlib,cs4231a,es1370,gus,sb16}.c.
>>
>> Why audio files are such a special thing?
>
> Because they are consistently formatted the way they are.

I personally hate the QEMU Coding Style I dislike inconsistency more than any 
particular style.

So I'm with malc here.  I'd be opposed to introducing a new file that deviated 
from Coding Style but for the ones that already do, I see no reason to convert 
them all at once or make the code deviate from the style it's already using.

>
>> Isn't it be better to revert a patch that introduced checkpatch.pl errors?
>
> No.

Regards,

Anthony Liguori


>

  reply	other threads:[~2012-02-10 17:49 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-09 14:59 [Qemu-devel] [PATCH] checkpatch: Don't WARN about missing spaces in audio files Andreas Färber
2012-02-09 15:03 ` Andreas Färber
2012-02-09 16:43 ` malc
2012-02-10  3:50 ` Evgeny Voevodin
2012-02-10  4:02   ` malc
2012-02-10 17:47     ` Anthony Liguori [this message]
2012-02-11  9:44       ` Blue Swirl
2012-02-17 14:31         ` Anthony Liguori
2012-02-17 14:55           ` Markus Armbruster
2012-02-17 15:26             ` Anthony Liguori
2012-02-18  9:13               ` Blue Swirl
2012-02-18 10:56                 ` Stefan Weil
2012-02-18 14:18                   ` Anthony Liguori
2012-02-18 14:34                     ` Blue Swirl
2012-02-18 15:53                 ` Andreas Färber
2012-02-18 16:47                   ` Eric Blake
2012-02-18  8:56           ` Blue Swirl
2012-02-18  9:07             ` [Qemu-devel] [PATCH] astyle: Formatting rules for QEMU Stefan Weil
2012-02-18 10:10               ` Blue Swirl
2012-02-18 11:13                 ` Stefan Weil
2012-02-11  9:37 ` [Qemu-devel] [PATCH] checkpatch: Don't WARN about missing spaces in audio files Blue Swirl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F355845.5040902@us.ibm.com \
    --to=aliguori@us.ibm.com \
    --cc=agraf@suse.de \
    --cc=av1474@comtv.ru \
    --cc=blauwirbel@gmail.com \
    --cc=e.voevodin@samsung.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).