From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:46820)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1Rvub1-00070I-4Z
	for qemu-devel@nongnu.org; Fri, 10 Feb 2012 12:49:19 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1Rvuav-00039y-BW
	for qemu-devel@nongnu.org; Fri, 10 Feb 2012 12:49:19 -0500
Received: from e33.co.us.ibm.com ([32.97.110.151]:33064)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1Rvuav-00038w-0Z
	for qemu-devel@nongnu.org; Fri, 10 Feb 2012 12:49:13 -0500
Received: from /spool/local
	by e33.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only!
	Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <aliguori@us.ibm.com>;
	Fri, 10 Feb 2012 10:49:08 -0700
Received: from d03relay03.boulder.ibm.com (d03relay03.boulder.ibm.com
	[9.17.195.228])
	by d03dlp02.boulder.ibm.com (Postfix) with ESMTP id 7AF823E40051
	for <qemu-devel@nongnu.org>; Fri, 10 Feb 2012 10:48:04 -0700 (MST)
Received: from d03av05.boulder.ibm.com (d03av05.boulder.ibm.com [9.17.195.85])
	by d03relay03.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP
	id q1AHlrvk055604
	for <qemu-devel@nongnu.org>; Fri, 10 Feb 2012 10:47:58 -0700
Received: from d03av05.boulder.ibm.com (loopback [127.0.0.1])
	by d03av05.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP
	id q1AHlpXI013114
	for <qemu-devel@nongnu.org>; Fri, 10 Feb 2012 10:47:52 -0700
Message-ID: <4F355845.5040902@us.ibm.com>
Date: Fri, 10 Feb 2012 11:47:49 -0600
From: Anthony Liguori <aliguori@us.ibm.com>
MIME-Version: 1.0
References: <1328799563-18932-1-git-send-email-afaerber@suse.de>	<4F349415.2000507@samsung.com>
	<alpine.LNX.2.00.1202100801170.4898@linmac>
In-Reply-To: <alpine.LNX.2.00.1202100801170.4898@linmac>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] checkpatch: Don't WARN about missing
 spaces in audio files
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: malc <av1474@comtv.ru>
Cc: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, Evgeny Voevodin <e.voevodin@samsung.com>, Alexander Graf <agraf@suse.de>, qemu-devel@nongnu.org, Blue Swirl <blauwirbel@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>

On 02/09/2012 10:02 PM, malc wrote:
> On Fri, 10 Feb 2012, Evgeny Voevodin wrote:
>
>> On 02/09/2012 06:59 PM, Andreas F?rber wrote:
>>> Disable warnings for spaces before opening parenthesis in
>>> hw/{ac97,adlib,cs4231a,es1370,gus,sb16}.c.
>>
>> Why audio files are such a special thing?
>
> Because they are consistently formatted the way they are.

I personally hate the QEMU Coding Style I dislike inconsistency more than any 
particular style.

So I'm with malc here.  I'd be opposed to introducing a new file that deviated 
from Coding Style but for the ones that already do, I see no reason to convert 
them all at once or make the code deviate from the style it's already using.

>
>> Isn't it be better to revert a patch that introduced checkpatch.pl errors?
>
> No.

Regards,

Anthony Liguori


>