From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:54945)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1RwBPq-0004yF-7N
	for qemu-devel@nongnu.org; Sat, 11 Feb 2012 06:46:55 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1RwBPp-0003VS-7x
	for qemu-devel@nongnu.org; Sat, 11 Feb 2012 06:46:54 -0500
Received: from cantor2.suse.de ([195.135.220.15]:60609 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1RwBPp-0003VO-3H
	for qemu-devel@nongnu.org; Sat, 11 Feb 2012 06:46:53 -0500
Message-ID: <4F36552A.3060604@suse.de>
Date: Sat, 11 Feb 2012 12:46:50 +0100
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <cover.1328898681.git.jan.kiszka@siemens.com>
	<104a9888a110afd0df281925dca2f05a64fa0ac6.1328898681.git.jan.kiszka@siemens.com>
In-Reply-To: <104a9888a110afd0df281925dca2f05a64fa0ac6.1328898681.git.jan.kiszka@siemens.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v2 7/8] optionsrom: Reserve space for
	checksum
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, kvm@vger.kernel.org, Gleb Natapov <gleb@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, Avi Kivity <avi@redhat.com>

Am 10.02.2012 19:31, schrieb Jan Kiszka:
> Always add a byte before the final 512-bytes alignment to reserve the
> space for the ROM checksum.
>=20
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  pc-bios/optionrom/optionrom.h |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>=20
> diff --git a/pc-bios/optionrom/optionrom.h b/pc-bios/optionrom/optionro=
m.h
> index aa783de..3daf7da 100644
> --- a/pc-bios/optionrom/optionrom.h
> +++ b/pc-bios/optionrom/optionrom.h
> @@ -124,7 +124,8 @@
>  	movw		%ax, %ds;
> =20
>  #define OPTION_ROM_END					\
> -    .align 512, 0;					\
> +	.byte		0;				\
> +	.align		512, 0;				\

Tabs.

Andreas

>      _end:
> =20
>  #define BOOT_ROM_END					\

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg