From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:50185) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RwBu6-0001at-EU for qemu-devel@nongnu.org; Sat, 11 Feb 2012 07:18:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RwBu5-000805-AD for qemu-devel@nongnu.org; Sat, 11 Feb 2012 07:18:10 -0500 Received: from cantor2.suse.de ([195.135.220.15]:33664 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RwBu5-0007zp-1C for qemu-devel@nongnu.org; Sat, 11 Feb 2012 07:18:09 -0500 Message-ID: <4F365C7E.4080409@suse.de> Date: Sat, 11 Feb 2012 13:18:06 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <4F324A60.7070600@samsung.com> <4F326D66.6060808@suse.de> <4F329385.4030203@codemonkey.ws> <4F329660.7040101@suse.de> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] Restore consistent formatting List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: Evgeny Voevodin , Stefan Hajnoczi , qemu-devel@nongnu.org, Dmitry Solodkiy Am 11.02.2012 10:19, schrieb Blue Swirl: > On Wed, Feb 8, 2012 at 15:36, Andreas F=C3=A4rber wr= ote: >> This is not about whether or not we put a space somewhere. >> >> It's about reviewers and SubmitAPatch telling people to run >> checkpatch.pl on patches and checkpatch.pl reporting this as an ERROR, >> not a WARNING. So if you follow Stefan's instructions on running the >> script as a commit hook (which is the only sane way to run it when >> handling lots of patches) you can't commit a patch or your local chang= es >> when there are ERRORs. >=20 > The warning levels are from Linux, they could well be incorrect. My memory tricked me, I must've mixed it up with the other issue I was investigating (too little sleep and very annoyed about the monolithic fragments of Perl source code and checkpatch.pl not conforming to its own rules, e.g. tab indention and > 80 chars). Still, my point remains: what shows up in checkpatch.pl output will get fixed by new contributors, whether WARNING or ERROR. And checkpatch.pl cannot distinguish between changes that correctly update old-style code (e.g., adding braces for if) and code that aims for consistency in a file. Leaving checkpatch.pl unchanged and demanding this special case doesn't go along well and will cause frustration on all sides and reformatting back and forth, something that was declared forbidden elsewhere and patches doing reformattings were turned down. Andreas P.S. For the record, Stefan pointed me to git-commit --no-verify for ignoring checkpatch ERRORs. --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg