From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:41227) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RwCPz-0000Ff-EG for qemu-devel@nongnu.org; Sat, 11 Feb 2012 07:51:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RwCPy-0003zC-39 for qemu-devel@nongnu.org; Sat, 11 Feb 2012 07:51:07 -0500 Received: from cantor2.suse.de ([195.135.220.15]:35145 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RwCPx-0003z8-Rc for qemu-devel@nongnu.org; Sat, 11 Feb 2012 07:51:06 -0500 Message-ID: <4F366436.70900@suse.de> Date: Sat, 11 Feb 2012 13:51:02 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <104a9888a110afd0df281925dca2f05a64fa0ac6.1328898681.git.jan.kiszka@siemens.com> <4F36552A.3060604@suse.de> <4F3662E9.9040803@web.de> In-Reply-To: <4F3662E9.9040803@web.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 7/8] optionsrom: Reserve space for checksum List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Anthony Liguori , kvm@vger.kernel.org, Gleb Natapov , Marcelo Tosatti , qemu-devel , Avi Kivity -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 11.02.2012 13:45, schrieb Jan Kiszka: > On 2012-02-11 12:46, Andreas F=E4rber wrote: >> Am 10.02.2012 19:31, schrieb Jan Kiszka: >>> Always add a byte before the final 512-bytes alignment to >>> reserve the space for the ROM checksum. >>>=20 >>> Signed-off-by: Jan Kiszka ---=20 >>> pc-bios/optionrom/optionrom.h | 3 ++- 1 files changed, 2 >>> insertions(+), 1 deletions(-) >>>=20 >>> diff --git a/pc-bios/optionrom/optionrom.h >>> b/pc-bios/optionrom/optionrom.h index aa783de..3daf7da 100644=20 >>> --- a/pc-bios/optionrom/optionrom.h +++ >>> b/pc-bios/optionrom/optionrom.h @@ -124,7 +124,8 @@ movw %ax, >>> %ds; >>>=20 >>> #define OPTION_ROM_END \ - .align 512, 0; \ + .byte >>> 0; \ + .align 512, 0; \ >>=20 >> Tabs. >=20 > For sure, like in the whole file. No, as we can see in this patch, .align above and _align below use 4 spaces, so this looks inconsistent in Thunderbird. I don't really mind, just noticed and thought you might want to fix. Andreas >=20 > If a codestyle fix is desired, I'll post one for all assembly > files. But I guess there are different views on such changes. >=20 > Jan - --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (GNU/Linux) iQIcBAEBAgAGBQJPNmQ2AAoJEPou0S0+fgE/nnEQALknNqkUrCgdXTiRwaKCZehU U+lnRwAY2DoFKaq8IqmvmiwNW2g4U0qPy0Stc7qvsOeTHSk/MX3R1Ym1+a03Hk22 tIzyJjvQPgVkbQtAljC7BObGzxGq9mUlV4+/TuTQgTsDXig121CmVVmrKXDRdP6o vXmtLgkXQB75ArOQSr0sByCFuBbA+AlIcmtIpvlR6znMZcfp0QFYbAzfAINzad+A Qg40GXUsFyyHlstM3Njt9H0ArtvE+NIPH9ZABk+58aV92CAk31rOigiiBAE1sPja qR0AIEMmwnASEWsn/yX45b+lhxXfVadZNzobhnJ/KqG/K7hrfzcLIeD5pKMt8USu TPFfdswt4utm/JDGhP9moRpe3cLGITAN93vybyOv/7W0CK18etFgevQvX0C98V9O +FUjwqsOwfXkswXcglwYmUVqJarUooh1MlXF/QnS+/d7aefIl59Y/YaGzRryjZNm Nd1hN7L5J34LfBCgltWNXA9KQB+0LyCYCX0lzE1+428WwqbZ8nGa9ZiUY0w4N2O7 maWrWnmI1VsiUL8RdsQpx7+nRfUEZW6JDfm1bA5nbd+uLuE+TwpAWWkC2kVOhnfi UQggicoM6J88zcbiGT74whjfZgx7CXcE/F/Tncd5ebi5qi++jXB6C0f3LSFcx2KP +Zv19XpWHzZXNNYiGFW0 =3DrQEQ -----END PGP SIGNATURE-----