Re: [Qemu-devel] [PATCH v2 7/8] optionsrom: Reserve space for checksum

[Jan Kiszka <jan.kiszka@web.de>]

[-- Attachment #1: Type: text/plain, Size: 1455 bytes --]

On 2012-02-11 13:51, Andreas Färber wrote:
> Am 11.02.2012 13:45, schrieb Jan Kiszka:
>> On 2012-02-11 12:46, Andreas Färber wrote:
>>> Am 10.02.2012 19:31, schrieb Jan Kiszka:
>>>> Always add a byte before the final 512-bytes alignment to
>>>> reserve the space for the ROM checksum.
>>>>
>>>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> --- 
>>>> pc-bios/optionrom/optionrom.h |    3 ++- 1 files changed, 2
>>>> insertions(+), 1 deletions(-)
>>>>
>>>> diff --git a/pc-bios/optionrom/optionrom.h
>>>> b/pc-bios/optionrom/optionrom.h index aa783de..3daf7da 100644 
>>>> --- a/pc-bios/optionrom/optionrom.h +++
>>>> b/pc-bios/optionrom/optionrom.h @@ -124,7 +124,8 @@ movw		%ax,
>>>> %ds;
>>>>
>>>> #define OPTION_ROM_END					\ -    .align 512, 0;					\ +	.byte
>>>> 0;				\ +	.align		512, 0;				\
>>>
>>> Tabs.
> 
>> For sure, like in the whole file.
> 
> No, as we can see in this patch, .align above and _align below use 4
> spaces, so this looks inconsistent in Thunderbird.

Right, but that is consistent with other labels in this file. OTOH,
label indention is different again in the option rom source files. Well,
no optimal solution here... ;)

Thanks,
Jan

> 
> I don't really mind, just noticed and thought you might want to fix.
> 
> Andreas
> 
> 
>> If a codestyle fix is desired, I'll post one for all assembly
>> files. But I guess there are different views on such changes.
> 
>> Jan
> 


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]