From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:40661) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RwCWQ-0002Co-LA for qemu-devel@nongnu.org; Sat, 11 Feb 2012 07:57:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RwCWP-0004fQ-DJ for qemu-devel@nongnu.org; Sat, 11 Feb 2012 07:57:46 -0500 Received: from fmmailgate03.web.de ([217.72.192.234]:38487) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RwCWP-0004fF-1W for qemu-devel@nongnu.org; Sat, 11 Feb 2012 07:57:45 -0500 Received: from moweb002.kundenserver.de (moweb002.kundenserver.de [172.19.20.108]) by fmmailgate03.web.de (Postfix) with ESMTP id EF81C1B1028B0 for ; Sat, 11 Feb 2012 13:57:43 +0100 (CET) Message-ID: <4F3665C6.6020805@web.de> Date: Sat, 11 Feb 2012 13:57:42 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <104a9888a110afd0df281925dca2f05a64fa0ac6.1328898681.git.jan.kiszka@siemens.com> <4F36552A.3060604@suse.de> <4F3662E9.9040803@web.de> <4F366436.70900@suse.de> In-Reply-To: <4F366436.70900@suse.de> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig52FA7D12C4FAD4A12E7EBDA6" Subject: Re: [Qemu-devel] [PATCH v2 7/8] optionsrom: Reserve space for checksum List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-15?Q?Andreas_F=E4rber?= Cc: Anthony Liguori , kvm@vger.kernel.org, Gleb Natapov , Marcelo Tosatti , qemu-devel , Avi Kivity This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig52FA7D12C4FAD4A12E7EBDA6 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable On 2012-02-11 13:51, Andreas F=E4rber wrote: > Am 11.02.2012 13:45, schrieb Jan Kiszka: >> On 2012-02-11 12:46, Andreas F=E4rber wrote: >>> Am 10.02.2012 19:31, schrieb Jan Kiszka: >>>> Always add a byte before the final 512-bytes alignment to >>>> reserve the space for the ROM checksum. >>>> >>>> Signed-off-by: Jan Kiszka ---=20 >>>> pc-bios/optionrom/optionrom.h | 3 ++- 1 files changed, 2 >>>> insertions(+), 1 deletions(-) >>>> >>>> diff --git a/pc-bios/optionrom/optionrom.h >>>> b/pc-bios/optionrom/optionrom.h index aa783de..3daf7da 100644=20 >>>> --- a/pc-bios/optionrom/optionrom.h +++ >>>> b/pc-bios/optionrom/optionrom.h @@ -124,7 +124,8 @@ movw %ax, >>>> %ds; >>>> >>>> #define OPTION_ROM_END \ - .align 512, 0; \ + .byte >>>> 0; \ + .align 512, 0; \ >>> >>> Tabs. >=20 >> For sure, like in the whole file. >=20 > No, as we can see in this patch, .align above and _align below use 4 > spaces, so this looks inconsistent in Thunderbird. Right, but that is consistent with other labels in this file. OTOH, label indention is different again in the option rom source files. Well, no optimal solution here... ;) Thanks, Jan >=20 > I don't really mind, just noticed and thought you might want to fix. >=20 > Andreas >=20 >=20 >> If a codestyle fix is desired, I'll post one for all assembly >> files. But I guess there are different views on such changes. >=20 >> Jan >=20 --------------enig52FA7D12C4FAD4A12E7EBDA6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk82ZcYACgkQitSsb3rl5xTJjQCggcD8d7vWQIQrRZzwhRoEfNs8 CnsAnAixIm2J0JRhkygpoHigNiIIQjKD =PM84 -----END PGP SIGNATURE----- --------------enig52FA7D12C4FAD4A12E7EBDA6--