From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:48219) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RwCfn-0004x2-2X for qemu-devel@nongnu.org; Sat, 11 Feb 2012 08:07:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RwCfl-0006CA-SQ for qemu-devel@nongnu.org; Sat, 11 Feb 2012 08:07:27 -0500 Received: from fmmailgate05.web.de ([217.72.192.243]:32899) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RwCfl-0006C6-Gg for qemu-devel@nongnu.org; Sat, 11 Feb 2012 08:07:25 -0500 Received: from moweb002.kundenserver.de (moweb002.kundenserver.de [172.19.20.108]) by fmmailgate05.web.de (Postfix) with ESMTP id D1FAD6968ED4 for ; Sat, 11 Feb 2012 14:07:24 +0100 (CET) Message-ID: <4F36680B.7090400@web.de> Date: Sat, 11 Feb 2012 14:07:23 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <4F363DB2.3080908@web.de> <4F3655E7.3090905@suse.de> <4F36626D.7020109@web.de> <4F3667BC.9060306@suse.de> In-Reply-To: <4F3667BC.9060306@suse.de> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig781C05AC8F7128F3CF6AD30E" Subject: Re: [Qemu-devel] [PATCH v2 1/8] kvm: Set cpu_single_env only once List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Cc: Anthony Liguori , kvm@vger.kernel.org, Gleb Natapov , Marcelo Tosatti , qemu-devel , Blue Swirl , Avi Kivity This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig781C05AC8F7128F3CF6AD30E Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 2012-02-11 14:06, Andreas F=C3=A4rber wrote: > Am 11.02.2012 13:43, schrieb Jan Kiszka: >> On 2012-02-11 12:49, Andreas F=C3=A4rber wrote: >>> Am 11.02.2012 12:25, schrieb Blue Swirl: >>>> I think using cpu_single_env is an indication of a problem, >>>> like poor code, layering violation or poor API (vmport). What >>>> is your use case? >>> >>> I couldn't spot any in this series. Jan, note that any new use of >>> env or cpu_single_env will need to be redone when we convert to >>> QOM CPU. >=20 >> cpu_single_env should have nothing to do with QOM. >=20 > It does, cf. my patch series: Current CPU*State is being embedded in > the QOM object and most future code outside TCG will use a CPU rather > than CPUState pointer. The reason is that CPUState is totally > target-specific and does not belong in common code. So are the devices that depend on a current CPU pointer. You will have to provide something equivalent. Jan --------------enig781C05AC8F7128F3CF6AD30E Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk82aAsACgkQitSsb3rl5xSYxwCgxt2/qCo1vLkjOZW2KiRDMDbH W1QAnjUdxI0Hj4jYTSF5K1Wl+zxpvS8A =15xk -----END PGP SIGNATURE----- --------------enig781C05AC8F7128F3CF6AD30E--