From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:59064) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RwCts-0000qb-EF for qemu-devel@nongnu.org; Sat, 11 Feb 2012 08:22:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RwCtr-00089w-4A for qemu-devel@nongnu.org; Sat, 11 Feb 2012 08:22:00 -0500 Received: from cantor2.suse.de ([195.135.220.15]:36570 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RwCtq-00089n-Pb for qemu-devel@nongnu.org; Sat, 11 Feb 2012 08:21:59 -0500 Message-ID: <4F366B74.1000501@suse.de> Date: Sat, 11 Feb 2012 14:21:56 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <4F363DB2.3080908@web.de> <4F3655E7.3090905@suse.de> <4F36626D.7020109@web.de> <4F3667BC.9060306@suse.de> <4F36680B.7090400@web.de> In-Reply-To: <4F36680B.7090400@web.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 1/8] kvm: Set cpu_single_env only once List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Anthony Liguori , kvm@vger.kernel.org, Gleb Natapov , Marcelo Tosatti , qemu-devel , Blue Swirl , Avi Kivity , Paolo Bonzini -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 11.02.2012 14:07, schrieb Jan Kiszka: > On 2012-02-11 14:06, Andreas F=C3=A4rber wrote: >> Am 11.02.2012 13:43, schrieb Jan Kiszka: >>> On 2012-02-11 12:49, Andreas F=C3=A4rber wrote: >>>> Am 11.02.2012 12:25, schrieb Blue Swirl: >>>>> I think using cpu_single_env is an indication of a >>>>> problem, like poor code, layering violation or poor API >>>>> (vmport). What is your use case? >>>>=20 >>>> I couldn't spot any in this series. Jan, note that any new >>>> use of env or cpu_single_env will need to be redone when we >>>> convert to QOM CPU. >>=20 >>> cpu_single_env should have nothing to do with QOM. >>=20 >> It does, cf. my patch series: Current CPU*State is being embedded >> in the QOM object and most future code outside TCG will use a Let me stress this: >> CPU rather than CPUState pointer. >> The reason is that CPUState is totally target-specific and does >> not belong in common code. >=20 > So are the devices that depend on a current CPU pointer. You will > have to provide something equivalent. CPU base class v3: http://patchwork.ozlabs.org/patch/139284/ (v4 coming up) That doesn't prevent target-specific devices. Although Paolo does want that to change wrt properties. Andreas - --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (GNU/Linux) iQIcBAEBAgAGBQJPNmtzAAoJEPou0S0+fgE/SRQP+gLK/FvwIOXZqvSn+i+ooxin jXOvH3oBtfiIQp5+59KGlOd7dSjILFwoPtH3U5tGDpI5HHLFpQQOsuppsiBwVOC9 9QUgqFt9d/xodvPJ0gv5ShghoEmCZNdFwNnBYeqB69mEDm5sZwYlvWgXaOgRti2+ 0lhGFVISetImmQbiy5l7ubMONwcGUCVuT7pjiZ+S/Cew7wvGW5O7fpo3P8b4Xw4E P7qX6y785Sm4Wn8iEangFOUqer5ALAS0fL2xHo5NYUUZ8jgn2xwDIT8TP9t8Pkei 5U0kWm+mNyvJ4VLxsN449LNGDV+c3AMyzPodRmV2KJBYISDRIFYlar/SkJGiBkvo cNKdJLrkm4KIEt6eomyhYgSHJi5nUeoT60lAaZkHIDNonKoFw8swhf85wSi7sQmq 38nIY+F5YAHZ3TQCfTfxTDHy2Wbc6G7bn792FWKOxCVLWtD2Bp3iQv8J3MlYEhMJ fnJv+/nKUQuPlti4LNwrhJyRLPUNrc6PKgzC8He4dupLMASFPuSMh4mKRlWj41+/ SYKvXz42elSqv2Z798eA8VNCbs7e+0EH67BJQLIL3QEuD4vY/Yfeulr3CGsfkLEL m+UIAAntzloSkZvxuKmI5MP5XrjHTAbWuab+Gh9kYVyEsWZj4TAvn1hobKtU7sv9 lMd32AbfCskRN8jAw8So =3D0Rvo -----END PGP SIGNATURE-----