From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:51778) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RwDTw-0000QY-Ku for qemu-devel@nongnu.org; Sat, 11 Feb 2012 08:59:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RwDTv-0004oK-AJ for qemu-devel@nongnu.org; Sat, 11 Feb 2012 08:59:16 -0500 Received: from cantor2.suse.de ([195.135.220.15]:38546 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RwDTu-0004oG-Uv for qemu-devel@nongnu.org; Sat, 11 Feb 2012 08:59:15 -0500 Message-ID: <4F36742F.2050600@suse.de> Date: Sat, 11 Feb 2012 14:59:11 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <4F363DB2.3080908@web.de> <4F3655E7.3090905@suse.de> <4F36626D.7020109@web.de> <4F3667BC.9060306@suse.de> <4F36680B.7090400@web.de> <4F366B74.1000501@suse.de> <4F366E9C.8080808@web.de> In-Reply-To: <4F366E9C.8080808@web.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 1/8] kvm: Set cpu_single_env only once List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Anthony Liguori , kvm@vger.kernel.org, Gleb Natapov , Marcelo Tosatti , qemu-devel , Blue Swirl , Avi Kivity , Paolo Bonzini -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 11.02.2012 14:35, schrieb Jan Kiszka: > On 2012-02-11 14:21, Andreas F=C3=A4rber wrote: >> CPU base class v3: http://patchwork.ozlabs.org/patch/139284/ (v4 >> coming up) >>=20 >> That doesn't prevent target-specific devices. Although Paolo does >> want that to change wrt properties. >=20 > This patch doesn't explain yet what shall happen to cpu_single_env > and CPUState accesses from target-specific devices. True. We can't change them before all targets are converted. So far I have 3/14 and still some review comments to work in. Another patch in that series uses a macro s/ENV_GET_OBJECT/ENV_GET_CPU/ to go from CPUState -> CPU while we convert targets. Depending on our taste, cpu_single_env might become cpu_single_cpu, single_cpu or cpu_single. > Do you plan accessors for registers? No, registers are in target-specific ARMCPU, S390CPU, MIPSCPU, etc. and their CPU*State. It would be possible to have static inline accessors but so far I've seen no need. > And a service to return the CPU object associated with the > execution context? What do you mean by execution context? TLS? The modelling of the state is pretty orthogonal to how/where we store it. HTE, Andreas - --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (GNU/Linux) iQIcBAEBAgAGBQJPNnQvAAoJEPou0S0+fgE/yYAP/j4IUTrrP1invYoVLOiea7wn 9yJ3TgssSUPnQyQRUmkXFvx1hj0Z6umlyxTK+dc1DQF8jJtoouo3CS0D+tyIZEhd GHN9J0qtgiDzvl1c+3b092VTw47gtv+rXjGUcyKSiTqyGl3OCdbIgt21HK8cT6CN U7n2pFGBeZiX8GEYiZmhAglyJ45jGpWmVulGYiqzOlBYPLaYi0CQ25NVUalBpq4I MIEqdW/W8lx0+h5Onl+qUo2btHNQCnG1oPH/BmdVf7Pe1G99VynOXwFVNXeJ2gR4 Lb7wnzKFqdybktkNLtkAIuC0gFj+Ph9+wfVw/QGsCBc0r6gotE8O9uDTyxs1ro+2 in6Am/A+o4M02sOf9uhaYx0l3uryOyXifiIAVzj4Y8s0QhyeDfPa6f8p4iQKh+gE m/bvbDTb5hU9nW68IuiFXK9dfQMmU2ub5Gx7UAHuyOgEzV0gOPAf4nugYux3owIw kYJy6sWFUMH/+l94nKAI0FanmL6JSOmA8hfaLXCXOfvfX9CfJEN+KEotj7Ma0Tcz +YFAlGkwZYmnJmvFakxFlecRUYY/lpwlIusqRJsw1KP40pHuT8GZUDzv6Wn1UD2R /6xeL7007iUmD+mafc+3xFbKMXS+kyF6+syM3xh/7r1SRyAIZQeJnZvLm8pZXS0T tsKlb6nYaV+NLwD/rKy0 =3D09lZ -----END PGP SIGNATURE-----