From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:55308)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <supriyak@linux.vnet.ibm.com>) id 1Rwvj5-00042m-6m
	for qemu-devel@nongnu.org; Mon, 13 Feb 2012 08:13:55 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <supriyak@linux.vnet.ibm.com>) id 1Rwviz-0001aT-Mz
	for qemu-devel@nongnu.org; Mon, 13 Feb 2012 08:13:51 -0500
Received: from e28smtp03.in.ibm.com ([122.248.162.3]:52242)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <supriyak@linux.vnet.ibm.com>) id 1Rwviz-0001aC-2n
	for qemu-devel@nongnu.org; Mon, 13 Feb 2012 08:13:45 -0500
Received: from /spool/local
	by e28smtp03.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <supriyak@linux.vnet.ibm.com>;
	Mon, 13 Feb 2012 18:43:42 +0530
Received: from d28av01.in.ibm.com (d28av01.in.ibm.com [9.184.220.63])
	by d28relay05.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	q1DDDadr3944588
	for <qemu-devel@nongnu.org>; Mon, 13 Feb 2012 18:43:37 +0530
Received: from d28av01.in.ibm.com (loopback [127.0.0.1])
	by d28av01.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	q1DDDaZ6009893
	for <qemu-devel@nongnu.org>; Mon, 13 Feb 2012 18:43:36 +0530
Message-ID: <4F390C7F.6040905@linux.vnet.ibm.com>
Date: Mon, 13 Feb 2012 18:43:35 +0530
From: Supriya Kannery <supriyak@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <20120201030557.2990.74150.sendpatchset@skannery.in.ibm.com>
	<20120201030628.2990.42721.sendpatchset@skannery.in.ibm.com>
	<20120207075634.GA29427@stefanha-thinkpad.localdomain>
In-Reply-To: <20120207075634.GA29427@stefanha-thinkpad.localdomain>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC Patch 2/7]Qemu: Error classes for file reopen
 and data sync failure
Reply-To: supriyak@linux.vnet.ibm.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Luiz Capitulino <lcapitulino@redhat.com>, Christoph Hellwig <hch@lst.de>, qemu-devel@nongnu.org

On 02/07/2012 01:26 PM, Stefan Hajnoczi wrote:
> On Wed, Feb 01, 2012 at 08:36:28AM +0530, Supriya Kannery wrote:
>> Index: qemu/qerror.c
>> ===================================================================
>> --- qemu.orig/qerror.c
>> +++ qemu/qerror.c
>> @@ -108,6 +108,14 @@ static const QErrorStringTable qerror_ta
>>           .desc      = "Device '%(device)' has multiple child busses",
>>       },
>>       {
>> +        .error_fmt = QERR_DATA_SYNC_FAILED,
>> +        .desc      = "Syncing of data failed for device '%(device)'",
>> +    },
>> +    {
>> +        .error_fmt = QERR_REOPEN_FILE_FAILED,
>> +        .desc      = "Could not reopen '%(filename)'",
>> +    },
>
> The comment in qerror.c says:
>
> "Please keep the entries in alphabetical order.
> Use scripts/check-qerror.sh to check."
>

ok

>> +    {
>>           .error_fmt = QERR_DEVICE_NO_BUS,
>>           .desc      = "Device '%(device)' has no child bus",
>>       },
>> Index: qemu/qerror.h
>> ===================================================================
>> --- qemu.orig/qerror.h
>> +++ qemu/qerror.h
>> @@ -117,6 +117,9 @@ QError *qobject_to_qerror(const QObject
>>   #define QERR_DEVICE_NOT_FOUND \
>>       "{ 'class': 'DeviceNotFound', 'data': { 'device': %s } }"
>>
>> +#define QERR_DATA_SYNC_FAILED \
>> +    "{ 'class': 'DataSyncFailed', 'data': { 'device': %s } }"
>> +
>
> Same here:
>
> /*
>   * QError class list
>   * Please keep the definitions in alphabetical order.
>   * Use scripts/check-qerror.sh to check.
>   */
>

ok