From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:50641)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <supriyak@linux.vnet.ibm.com>) id 1Rwvqb-0007IX-LW
	for qemu-devel@nongnu.org; Mon, 13 Feb 2012 08:21:38 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <supriyak@linux.vnet.ibm.com>) id 1Rwvqa-0003d1-Id
	for qemu-devel@nongnu.org; Mon, 13 Feb 2012 08:21:37 -0500
Received: from e28smtp02.in.ibm.com ([122.248.162.2]:60275)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <supriyak@linux.vnet.ibm.com>) id 1RwvqZ-0003c1-HY
	for qemu-devel@nongnu.org; Mon, 13 Feb 2012 08:21:36 -0500
Received: from /spool/local
	by e28smtp02.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <supriyak@linux.vnet.ibm.com>;
	Mon, 13 Feb 2012 18:51:32 +0530
Received: from d28av05.in.ibm.com (d28av05.in.ibm.com [9.184.220.67])
	by d28relay04.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	q1DDLNwx4268092
	for <qemu-devel@nongnu.org>; Mon, 13 Feb 2012 18:51:24 +0530
Received: from d28av05.in.ibm.com (loopback [127.0.0.1])
	by d28av05.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	q1DDLLBC007848
	for <qemu-devel@nongnu.org>; Tue, 14 Feb 2012 00:21:23 +1100
Message-ID: <4F390E4F.6080109@linux.vnet.ibm.com>
Date: Mon, 13 Feb 2012 18:51:19 +0530
From: Supriya Kannery <supriyak@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <20120201030557.2990.74150.sendpatchset@skannery.in.ibm.com>
	<20120201030641.2990.46503.sendpatchset@skannery.in.ibm.com>
	<20120208100749.71d73498@doriath.home>
In-Reply-To: <20120208100749.71d73498@doriath.home>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC Patch 3/7]Qemu: Cmd "block_set_hostcache" for
 dynamic cache change
Reply-To: supriyak@linux.vnet.ibm.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@gmail.com>, qemu-devel@nongnu.org, Christoph Hellwig <hch@lst.de>

On 02/08/2012 05:37 PM, Luiz Capitulino wrote:
> On Wed, 01 Feb 2012 08:36:41 +0530
> Supriya Kannery<supriyak@linux.vnet.ibm.com>  wrote:
>

>> +    ret = bdrv_open(bs, bs->filename, bdrv_flags, drv);
>> +    if (ret<  0) {
>> +        /* Reopen failed. Try to open with original flags */
>> +        qerror_report(QERR_REOPEN_FILE_FAILED, bs->filename);
>
> OPEN_FILE_FAILED is fine.
>

ok

>> +/*
>> + * Change host page cache setting while guest is running.
>> +*/
>> +int do_block_set_hostcache(Monitor *mon, const QDict *qdict,
>> +                           QObject **ret_data)
>
> This is not a QAPI command, please read docs/writing-qmp-commands.txt to know
> how to write QMP commands using the QAPI.
>

fine, will check the doc

-thanks, Supriya