qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Alex Barcelo <abarcelo@ac.upc.edu>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/3] coroutine: adding control flags (enable/disable) for ucontext compilation
Date: Mon, 13 Feb 2012 16:36:43 +0100	[thread overview]
Message-ID: <4F392E0B.4060809@redhat.com> (raw)
In-Reply-To: <1329144150-7720-3-git-send-email-abarcelo@ac.upc.edu>

Am 13.02.2012 15:42, schrieb Alex Barcelo:
> Configure tries, as a default, ucontext functions for the
> coroutines. But now the user can force its use or disable
> it at all (enable and disable flags)
> 
> Signed-off-by: Alex Barcelo <abarcelo@ac.upc.edu>

I think a better approach would be to have a
--coroutines=[ucontext|sigaltstack|gthread|windows] option, with the
appropriate default whereever it's possible to detect.

This would allow to build with gthread based coroutines even when
another option is available.

Kevin

  reply	other threads:[~2012-02-13 15:33 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-13 14:42 [Qemu-devel] [PATCH 0/3] New sigaltstack method for coroutine Alex Barcelo
2012-02-13 14:42 ` [Qemu-devel] [PATCH 1/3] coroutine: adding sigaltstack method (.c source) Alex Barcelo
2012-02-13 14:57   ` Paolo Bonzini
2012-02-13 15:57   ` Andreas Färber
2012-02-13 16:11     ` Alex Barcelo
2012-02-13 16:31       ` Andreas Färber
2012-02-13 22:20         ` Andreas Färber
2012-02-14  9:24   ` Stefan Hajnoczi
2012-02-14  9:50     ` Paolo Bonzini
2012-02-14 12:25       ` Stefan Hajnoczi
2012-03-06 21:14       ` Peter Maydell
2012-02-14 11:53     ` Alex Barcelo
2012-02-14 12:20       ` Stefan Hajnoczi
2012-02-14 13:21         ` Alex Barcelo
2012-02-14 15:12           ` Stefan Hajnoczi
2012-02-13 14:42 ` [Qemu-devel] [PATCH 2/3] coroutine: adding control flags (enable/disable) for ucontext compilation Alex Barcelo
2012-02-13 15:36   ` Kevin Wolf [this message]
2012-02-13 14:42 ` [Qemu-devel] [PATCH 3/3] coroutine: adding enable/disable options for sigaltstack method Alex Barcelo
2012-02-13 14:49   ` Daniel P. Berrange
2012-02-13 15:16     ` Alex Barcelo
2012-02-13 14:51 ` [Qemu-devel] [PATCH 0/3] New sigaltstack method for coroutine Peter Maydell
2012-02-13 15:11   ` Alex Barcelo
2012-02-14  8:33     ` Stefan Hajnoczi
2012-02-14 11:38       ` Alex Barcelo
2012-02-14 12:17         ` Stefan Hajnoczi
2012-02-14 13:12           ` Alex Barcelo
2012-02-14 15:11             ` Stefan Hajnoczi
2012-02-14 13:00 ` Paul Brook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F392E0B.4060809@redhat.com \
    --to=kwolf@redhat.com \
    --cc=abarcelo@ac.upc.edu \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).