From: Gerd Hoffmann <kraxel@redhat.com>
To: Yonit Halperin <yhalperi@redhat.com>
Cc: qemu-devel@nongnu.org, spice-devel@freedesktop.org
Subject: Re: [Qemu-devel] [PATCH] qxl: make sure primary surface is saved on migration also in compat mode
Date: Tue, 14 Feb 2012 09:35:32 +0100 [thread overview]
Message-ID: <4F3A1CD4.4070005@redhat.com> (raw)
In-Reply-To: <1329207018-7542-1-git-send-email-yhalperi@redhat.com>
On 02/14/12 09:10, Yonit Halperin wrote:
> RHBZ #790083
>
> Signed-off-by: Yonit Halperin <yhalperi@redhat.com>
You are doing two things in one patch: (a) fix the compat mode bug,
which also matches the patch description, and (b) skip vram when it is
unused (in compat mode).
I'd love to see (b) done in a different way: simply walk all surfaces
and tag them dirty. Will have the same effect for compat mode (no
surfaces used -> nothing tagged dirty) and additionally it will (in
native mode) only migrate over the vram areas which are actually filled
with surfaces.
thanks,
Gerd
next prev parent reply other threads:[~2012-02-14 8:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-14 8:10 [Qemu-devel] [PATCH] qxl: make sure primary surface is saved on migration also in compat mode Yonit Halperin
2012-02-14 8:35 ` Gerd Hoffmann [this message]
2012-02-14 9:10 ` Yonit Halperin
2012-02-14 9:15 ` [Qemu-devel] [Spice-devel] " Yonit Halperin
2012-02-14 9:24 ` [Qemu-devel] " Gerd Hoffmann
2012-02-14 9:33 ` Yonit Halperin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F3A1CD4.4070005@redhat.com \
--to=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=spice-devel@freedesktop.org \
--cc=yhalperi@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).