From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:41145) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RxDrS-00018Y-8g for qemu-devel@nongnu.org; Tue, 14 Feb 2012 03:35:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RxDrO-0002Mv-6X for qemu-devel@nongnu.org; Tue, 14 Feb 2012 03:35:42 -0500 Received: from mx1.redhat.com ([209.132.183.28]:29208) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RxDrN-0002Mo-TL for qemu-devel@nongnu.org; Tue, 14 Feb 2012 03:35:38 -0500 Message-ID: <4F3A1CD4.4070005@redhat.com> Date: Tue, 14 Feb 2012 09:35:32 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: <1329207018-7542-1-git-send-email-yhalperi@redhat.com> In-Reply-To: <1329207018-7542-1-git-send-email-yhalperi@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qxl: make sure primary surface is saved on migration also in compat mode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Yonit Halperin Cc: qemu-devel@nongnu.org, spice-devel@freedesktop.org On 02/14/12 09:10, Yonit Halperin wrote: > RHBZ #790083 > > Signed-off-by: Yonit Halperin You are doing two things in one patch: (a) fix the compat mode bug, which also matches the patch description, and (b) skip vram when it is unused (in compat mode). I'd love to see (b) done in a different way: simply walk all surfaces and tag them dirty. Will have the same effect for compat mode (no surfaces used -> nothing tagged dirty) and additionally it will (in native mode) only migrate over the vram areas which are actually filled with surfaces. thanks, Gerd