From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:39006) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RxEco-00089r-QE for qemu-devel@nongnu.org; Tue, 14 Feb 2012 04:24:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RxEck-0002wW-Rh for qemu-devel@nongnu.org; Tue, 14 Feb 2012 04:24:38 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49446) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RxEck-0002wQ-F5 for qemu-devel@nongnu.org; Tue, 14 Feb 2012 04:24:34 -0500 Message-ID: <4F3A284E.1080008@redhat.com> Date: Tue, 14 Feb 2012 10:24:30 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: <1329207018-7542-1-git-send-email-yhalperi@redhat.com> <4F3A1CD4.4070005@redhat.com> <4F3A2513.4060105@redhat.com> In-Reply-To: <4F3A2513.4060105@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qxl: make sure primary surface is saved on migration also in compat mode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Yonit Halperin Cc: qemu-devel@nongnu.org, spice-devel@freedesktop.org Hi, > I can do it, by retrieving the surfaces addresses from the tracked guest > commands. Exactly. > However, if we already do it, it would be even better if we > just dirty only the areas that are actually modified by the update_area > calls. The problem is that (1) spice-server updates surfaces also > without request from driver. On worker->stop() for example, which renderes all outstanding commands so all state is flushed to the surfaces (and thereby device memory). This is done on vm_stop too, so I wouldn't be surprised if most surfaces are dirtied anyway at this point. Getting notifications about spice-server touching surfaces doesn't buy us much then. cheers, Gerd