From: Yonit Halperin <yhalperi@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org, spice-devel@freedesktop.org
Subject: Re: [Qemu-devel] [PATCH] qxl: make sure primary surface is saved on migration also in compat mode
Date: Tue, 14 Feb 2012 11:33:35 +0200 [thread overview]
Message-ID: <4F3A2A6F.9010800@redhat.com> (raw)
In-Reply-To: <4F3A284E.1080008@redhat.com>
On 02/14/2012 11:24 AM, Gerd Hoffmann wrote:
> Hi,
>
>> I can do it, by retrieving the surfaces addresses from the tracked guest
>> commands.
>
> Exactly.
>
>> However, if we already do it, it would be even better if we
>> just dirty only the areas that are actually modified by the update_area
>> calls. The problem is that (1) spice-server updates surfaces also
>> without request from driver.
>
> On worker->stop() for example, which renderes all outstanding commands
> so all state is flushed to the surfaces (and thereby device memory).
> This is done on vm_stop too, so I wouldn't be surprised if most surfaces
> are dirtied anyway at this point. Getting notifications about
> spice-server touching surfaces doesn't buy us much then.
We also render drawables that are not hidden by other ones, when we lack
free memory in the driver.
In addition inter-surfaces dependencies are handled in a brute-force
manner by rendering old drawables (I plan to improve this). But anyway,
as I mentioned it the preceding email, since most of the surfaces are
destroyed (at least with the current drivers), I prefer not to dirty
them "live". So I'll make the change you originally suggested.
Regards,
Yonit.
>
> cheers,
> Gerd
>
prev parent reply other threads:[~2012-02-14 9:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-14 8:10 [Qemu-devel] [PATCH] qxl: make sure primary surface is saved on migration also in compat mode Yonit Halperin
2012-02-14 8:35 ` Gerd Hoffmann
2012-02-14 9:10 ` Yonit Halperin
2012-02-14 9:15 ` [Qemu-devel] [Spice-devel] " Yonit Halperin
2012-02-14 9:24 ` [Qemu-devel] " Gerd Hoffmann
2012-02-14 9:33 ` Yonit Halperin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F3A2A6F.9010800@redhat.com \
--to=yhalperi@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=spice-devel@freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).