From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Alex Barcelo <abarcelo@ac.upc.edu>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/3] coroutine: adding sigaltstack method (.c source)
Date: Tue, 14 Feb 2012 10:50:25 +0100 [thread overview]
Message-ID: <4F3A2E61.9060706@redhat.com> (raw)
In-Reply-To: <20120214092439.GC5686@stefanha-thinkpad.localdomain>
On 02/14/2012 10:24 AM, Stefan Hajnoczi wrote:
> setjmp() followed by return is usually bad. We're relying on the fact
> that the return code path here does not clobber local variables 'self'
> and 'co'. Can't we longjmp out back to the coroutine_new() function
> instead?
http://www.gnu.org/software/pth/rse-pmt.ps covers this. Basically, this
turned out to be more portable than longjmp from a signal handler.
Paolo
next prev parent reply other threads:[~2012-02-14 9:50 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-13 14:42 [Qemu-devel] [PATCH 0/3] New sigaltstack method for coroutine Alex Barcelo
2012-02-13 14:42 ` [Qemu-devel] [PATCH 1/3] coroutine: adding sigaltstack method (.c source) Alex Barcelo
2012-02-13 14:57 ` Paolo Bonzini
2012-02-13 15:57 ` Andreas Färber
2012-02-13 16:11 ` Alex Barcelo
2012-02-13 16:31 ` Andreas Färber
2012-02-13 22:20 ` Andreas Färber
2012-02-14 9:24 ` Stefan Hajnoczi
2012-02-14 9:50 ` Paolo Bonzini [this message]
2012-02-14 12:25 ` Stefan Hajnoczi
2012-03-06 21:14 ` Peter Maydell
2012-02-14 11:53 ` Alex Barcelo
2012-02-14 12:20 ` Stefan Hajnoczi
2012-02-14 13:21 ` Alex Barcelo
2012-02-14 15:12 ` Stefan Hajnoczi
2012-02-13 14:42 ` [Qemu-devel] [PATCH 2/3] coroutine: adding control flags (enable/disable) for ucontext compilation Alex Barcelo
2012-02-13 15:36 ` Kevin Wolf
2012-02-13 14:42 ` [Qemu-devel] [PATCH 3/3] coroutine: adding enable/disable options for sigaltstack method Alex Barcelo
2012-02-13 14:49 ` Daniel P. Berrange
2012-02-13 15:16 ` Alex Barcelo
2012-02-13 14:51 ` [Qemu-devel] [PATCH 0/3] New sigaltstack method for coroutine Peter Maydell
2012-02-13 15:11 ` Alex Barcelo
2012-02-14 8:33 ` Stefan Hajnoczi
2012-02-14 11:38 ` Alex Barcelo
2012-02-14 12:17 ` Stefan Hajnoczi
2012-02-14 13:12 ` Alex Barcelo
2012-02-14 15:11 ` Stefan Hajnoczi
2012-02-14 13:00 ` Paul Brook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F3A2E61.9060706@redhat.com \
--to=pbonzini@redhat.com \
--cc=abarcelo@ac.upc.edu \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).