From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:39259) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RxJzV-0005uu-BQ for qemu-devel@nongnu.org; Tue, 14 Feb 2012 10:08:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RxJzO-0003eB-Sn for qemu-devel@nongnu.org; Tue, 14 Feb 2012 10:08:25 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58607) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RxJzO-0003dz-MO for qemu-devel@nongnu.org; Tue, 14 Feb 2012 10:08:18 -0500 Message-ID: <4F3A79B0.5060807@redhat.com> Date: Tue, 14 Feb 2012 16:11:44 +0100 From: Kevin Wolf MIME-Version: 1.0 References: <1328563752-3976-1-git-send-email-hpoussin@reactos.org> <1328563752-3976-8-git-send-email-hpoussin@reactos.org> In-Reply-To: <1328563752-3976-8-git-send-email-hpoussin@reactos.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v4 07/11] pc: add 1.1 machine type List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= Cc: qemu-devel@nongnu.org Am 06.02.2012 22:29, schrieb Herv=C3=A9 Poussineau: >=20 > Signed-off-by: Herv=C3=A9 Poussineau > --- > hw/pc_piix.c | 11 ++++++++++- > 1 files changed, 10 insertions(+), 1 deletions(-) >=20 > diff --git a/hw/pc_piix.c b/hw/pc_piix.c > index c06f1b5..400c6b6 100644 > --- a/hw/pc_piix.c > +++ b/hw/pc_piix.c > @@ -371,9 +371,17 @@ static void pc_xen_hvm_init(ram_addr_t ram_size, > } > #endif > =20 > +static QEMUMachine pc_machine_v1_1 =3D { > + .name =3D "pc-1.1", > + .alias =3D "pc", > + .desc =3D "Standard PC", > + .init =3D pc_init_pci, > + .max_cpus =3D 255, > + .is_default =3D 1, > +}; Now we have three defaults. :-) I'll apply this anyway because we already do have two of them and three doesn't really make it worse, but a patch on top would be good. Kevin