qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: "Hervé Poussineau" <hpoussin@reactos.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v4 00/11] Misc fixes for floppy emulation
Date: Tue, 14 Feb 2012 16:27:11 +0100	[thread overview]
Message-ID: <4F3A7D4F.3040902@redhat.com> (raw)
In-Reply-To: <1328563752-3976-1-git-send-email-hpoussin@reactos.org>

Am 06.02.2012 22:29, schrieb Hervé Poussineau:
> Here are misc fixes done by VirtualBox team.
> With these patches, floppy emulation is now good enough to run Xenix.
> 
> Changes v3->v4:
> - added pc-1.1 machine type
> - disable media transfer rate check on older machine types
> - save/restore media transfer rate when media transfer rate check enabled
> 
> Changes v2->v3:
> - removed patch changing controller stepping to 0
> - fixed out of bound access after bad seek command
> 
> Changes v1->v2:
> - updated commit messages
> - added missing 'break' and braces
> 
> Hervé Poussineau (11):
>   fdc: take side count into account
>   fdc: set busy bit when starting a command
>   fdc: most control commands do not generate interrupts
>   fdc: handle read-only floppies (abort early on write commands)
>   fdc: add CCR (Configuration Control Register) write register
>   block: add a transfer rate for floppy types
>   pc: add 1.1 machine type
>   fdc: add a 'check media rate' property. Not used yet
>   fdc: check if media rate is correct before doing any transfer
>   fdc: fix seek command, which shouldn't check tracks
>   fdc: DIR (Digital Input Register) should return status of current
>     drive...
> 
>  block.c      |   74 ++++++++++++++++--------------
>  block.h      |   10 ++++-
>  hw/fdc.c     |  142 +++++++++++++++++++++++++++++++++++++++++++++++-----------
>  hw/pc.c      |    3 +-
>  hw/pc_piix.c |   47 +++++++++++++++++++-
>  5 files changed, 211 insertions(+), 65 deletions(-)

Thanks. I applied patches 1-5, 10 and 11 to the block branch, i.e.
leaving out the transfer rate stuff. I believe this is fairly
independent so it makes sense to apply the rest of the series without
it, but if you think I should dequeue all of the patches, let me know.

The main reason for not applying 6-9 is that I think migration is
broken, but I'll wait for Juan and/or Paolo to confirm. If a respin is
required, you can also fix the three default machine types.

Kevin

      parent reply	other threads:[~2012-02-14 15:23 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-06 21:29 [Qemu-devel] [PATCH v4 00/11] Misc fixes for floppy emulation Hervé Poussineau
2012-02-06 21:29 ` [Qemu-devel] [PATCH v4 01/11] fdc: take side count into account Hervé Poussineau
2012-02-06 21:29 ` [Qemu-devel] [PATCH v4 02/11] fdc: set busy bit when starting a command Hervé Poussineau
2012-02-06 21:29 ` [Qemu-devel] [PATCH v4 03/11] fdc: most control commands do not generate interrupts Hervé Poussineau
2012-02-06 21:29 ` [Qemu-devel] [PATCH v4 04/11] fdc: handle read-only floppies (abort early on write commands) Hervé Poussineau
2012-02-06 21:29 ` [Qemu-devel] [PATCH v4 05/11] fdc: add CCR (Configuration Control Register) write register Hervé Poussineau
2012-02-06 21:29 ` [Qemu-devel] [PATCH v4 06/11] block: add a transfer rate for floppy types Hervé Poussineau
2012-02-06 21:29 ` [Qemu-devel] [PATCH v4 07/11] pc: add 1.1 machine type Hervé Poussineau
2012-02-14 15:11   ` Kevin Wolf
2012-02-06 21:29 ` [Qemu-devel] [PATCH v4 08/11] fdc: add a 'check media rate' property. Not used yet Hervé Poussineau
2012-02-06 21:29 ` [Qemu-devel] [PATCH v4 09/11] fdc: check if media rate is correct before doing any transfer Hervé Poussineau
2012-02-14 15:16   ` Kevin Wolf
2012-02-14 15:28     ` Paolo Bonzini
2012-02-14 15:34       ` Kevin Wolf
2012-02-06 21:29 ` [Qemu-devel] [PATCH v4 10/11] fdc: fix seek command, which shouldn't check tracks Hervé Poussineau
2012-02-06 21:29 ` [Qemu-devel] [PATCH v4 11/11] fdc: DIR (Digital Input Register) should return status of current drive Hervé Poussineau
2012-02-14 12:31 ` [Qemu-devel] [PATCH v4 00/11] Misc fixes for floppy emulation Hervé Poussineau
2012-02-14 15:27 ` Kevin Wolf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F3A7D4F.3040902@redhat.com \
    --to=kwolf@redhat.com \
    --cc=hpoussin@reactos.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).