From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:48103) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RxKEQ-0003ev-G5 for qemu-devel@nongnu.org; Tue, 14 Feb 2012 10:23:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RxKEK-0006r3-Bo for qemu-devel@nongnu.org; Tue, 14 Feb 2012 10:23:50 -0500 Received: from mx1.redhat.com ([209.132.183.28]:19577) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RxKEK-0006qj-5F for qemu-devel@nongnu.org; Tue, 14 Feb 2012 10:23:44 -0500 Message-ID: <4F3A7D4F.3040902@redhat.com> Date: Tue, 14 Feb 2012 16:27:11 +0100 From: Kevin Wolf MIME-Version: 1.0 References: <1328563752-3976-1-git-send-email-hpoussin@reactos.org> In-Reply-To: <1328563752-3976-1-git-send-email-hpoussin@reactos.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v4 00/11] Misc fixes for floppy emulation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= Cc: qemu-devel@nongnu.org Am 06.02.2012 22:29, schrieb Herv=C3=A9 Poussineau: > Here are misc fixes done by VirtualBox team. > With these patches, floppy emulation is now good enough to run Xenix. >=20 > Changes v3->v4: > - added pc-1.1 machine type > - disable media transfer rate check on older machine types > - save/restore media transfer rate when media transfer rate check enabl= ed >=20 > Changes v2->v3: > - removed patch changing controller stepping to 0 > - fixed out of bound access after bad seek command >=20 > Changes v1->v2: > - updated commit messages > - added missing 'break' and braces >=20 > Herv=C3=A9 Poussineau (11): > fdc: take side count into account > fdc: set busy bit when starting a command > fdc: most control commands do not generate interrupts > fdc: handle read-only floppies (abort early on write commands) > fdc: add CCR (Configuration Control Register) write register > block: add a transfer rate for floppy types > pc: add 1.1 machine type > fdc: add a 'check media rate' property. Not used yet > fdc: check if media rate is correct before doing any transfer > fdc: fix seek command, which shouldn't check tracks > fdc: DIR (Digital Input Register) should return status of current > drive... >=20 > block.c | 74 ++++++++++++++++-------------- > block.h | 10 ++++- > hw/fdc.c | 142 +++++++++++++++++++++++++++++++++++++++++++++++---= -------- > hw/pc.c | 3 +- > hw/pc_piix.c | 47 +++++++++++++++++++- > 5 files changed, 211 insertions(+), 65 deletions(-) Thanks. I applied patches 1-5, 10 and 11 to the block branch, i.e. leaving out the transfer rate stuff. I believe this is fairly independent so it makes sense to apply the rest of the series without it, but if you think I should dequeue all of the patches, let me know. The main reason for not applying 6-9 is that I think migration is broken, but I'll wait for Juan and/or Paolo to confirm. If a respin is required, you can also fix the three default machine types. Kevin