From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:52936)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1RxN6c-0005hi-IV
	for qemu-devel@nongnu.org; Tue, 14 Feb 2012 13:28:02 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1RxN6b-0005Fm-Ky
	for qemu-devel@nongnu.org; Tue, 14 Feb 2012 13:27:58 -0500
Received: from goliath.siemens.de ([192.35.17.28]:34177)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1RxN6b-0005Fc-9T
	for qemu-devel@nongnu.org; Tue, 14 Feb 2012 13:27:57 -0500
Message-ID: <4F3AA7A2.7070507@siemens.com>
Date: Tue, 14 Feb 2012 19:27:46 +0100
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <4F333AAA.1070601@cn.fujitsu.com> <4F333EDE.600@cn.fujitsu.com>
In-Reply-To: <4F333EDE.600@cn.fujitsu.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC][PATCH 16/16 v6] allow user to dump a
	fraction of the memory
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Wen Congyang <wency@cn.fujitsu.com>
Cc: Eric Blake <eblake@redhat.com>, HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>, Dave Anderson <anderson@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, Luiz Capitulino <lcapitulino@redhat.com>

On 2012-02-09 04:34, Wen Congyang wrote:
> diff --git a/hmp-commands.hx b/hmp-commands.hx
> index a026905..388b9ac 100644
> --- a/hmp-commands.hx
> +++ b/hmp-commands.hx
> @@ -868,9 +868,11 @@ ETEXI
> 
>      {
>          .name       = "dump",
> -        .args_type  = "detach:-d,file:s",
> +        .args_type  = "detach:-d,file:s,begin:i?,length:i?",
>          .params     = "file",

You forgot to update params.

> -        .help       = "dump to file (using -d to not wait for completion)",
> +        .help       = "dump to file (using -d to not wait for completion)"
> +                      "\n\t\t\t begin(optional): the starting physical address"
> +                      "\n\t\t\t length(optional): the memory size, in bytes",

Is it [begin [lenght]] or [begin lenght]? If you specify params, you
don't need to state optional here.

Same for QMP.

I'm short on time, thus didn't look at code in patches >= 10.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux