From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:46944) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RxalO-0001VV-Vd for qemu-devel@nongnu.org; Wed, 15 Feb 2012 04:03:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RxalN-0000xA-Oz for qemu-devel@nongnu.org; Wed, 15 Feb 2012 04:02:58 -0500 Received: from david.siemens.de ([192.35.17.14]:23045) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RxalN-0000x4-EO for qemu-devel@nongnu.org; Wed, 15 Feb 2012 04:02:57 -0500 Message-ID: <4F3B74BE.30802@siemens.com> Date: Wed, 15 Feb 2012 10:02:54 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <1328902266-25308-1-git-send-email-lcapitulino@redhat.com> <1328902266-25308-6-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1328902266-25308-6-git-send-email-lcapitulino@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 5/6] Purge migration of (almost) everything to do with monitors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, quintela@redhat.com On 2012-02-10 20:31, Luiz Capitulino wrote: > The Monitor object is passed back and forth within the migration/savevm > code so that it can print errors and progress to the user. > > However, that approach assumes a HMP monitor, being completely invalid > in QMP. > > This commit drops almost every single usage of the Monitor object, all > monitor_printf() calls have been converted into DPRINTF() ones. Particularly NACK on this. Either the information is useless anyway, then remove it. Otherwise, keep it for channels that can properly display it (AKA HMP). I bet the latter can easily be achieved by providing non-printing Monitor objects over QMP instances. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux