From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:60824) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rxenk-0004cm-NQ for qemu-devel@nongnu.org; Wed, 15 Feb 2012 08:21:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RxenY-0008T2-Q2 for qemu-devel@nongnu.org; Wed, 15 Feb 2012 08:21:40 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33327) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RxenY-0008Sy-GB for qemu-devel@nongnu.org; Wed, 15 Feb 2012 08:21:28 -0500 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q1FDLRRj020245 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 15 Feb 2012 08:21:27 -0500 Message-ID: <4F3BB1A0.7050909@redhat.com> Date: Wed, 15 Feb 2012 15:22:40 +0200 From: Yonit Halperin MIME-Version: 1.0 References: <1329311466-20344-1-git-send-email-kraxel@redhat.com> In-Reply-To: <1329311466-20344-1-git-send-email-kraxel@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qxl: don't render stuff when the vm is stopped. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org Hi, On 02/15/2012 03:11 PM, Gerd Hoffmann wrote: > This patch fixes the local qxl renderer to not kick spice-server in case > the vm is stopped. First it is pointless because we render evevything > when the vm is stopped. Thus there is nothing to render anyway because > a stopped guest can hardly queue more commands. hmm...When the vm is stopped we render only commands that we already read. We don't do more reading from the command ring. So there may be other pending commands that were not rendered. That is why I suggested allowing rendering when the vm is stopped. But not allowing it during loading the vm during migration. Regards, Yonit. Second we avoid > triggering an assert in spice-server. > > With this patch applied it is possible to take screen shots (via > screendump monitor command) from a qxl gpu even in case the guest > is stopped. > > Signed-off-by: Gerd Hoffmann > --- > hw/qxl-render.c | 12 +++++------- > 1 files changed, 5 insertions(+), 7 deletions(-) > > diff --git a/hw/qxl-render.c b/hw/qxl-render.c > index 133d093..7084143 100644 > --- a/hw/qxl-render.c > +++ b/hw/qxl-render.c > @@ -121,19 +121,17 @@ void qxl_render_update(PCIQXLDevice *qxl) > dpy_resize(vga->ds); > } > > - if (!qxl->guest_primary.commands) { > - return; > - } > - qxl->guest_primary.commands = 0; > - > update.left = 0; > update.right = qxl->guest_primary.surface.width; > update.top = 0; > update.bottom = qxl->guest_primary.surface.height; > > memset(dirty, 0, sizeof(dirty)); > - qxl_spice_update_area(qxl, 0,&update, > - dirty, ARRAY_SIZE(dirty), 1, QXL_SYNC); > + if (runstate_is_running()&& qxl->guest_primary.commands) { > + qxl->guest_primary.commands = 0; > + qxl_spice_update_area(qxl, 0,&update, > + dirty, ARRAY_SIZE(dirty), 1, QXL_SYNC); > + } > if (redraw) { > memset(dirty, 0, sizeof(dirty)); > dirty[0] = update;