From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:60871) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RxfNj-0000Gh-BR for qemu-devel@nongnu.org; Wed, 15 Feb 2012 08:58:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RxfNd-0006lO-J5 for qemu-devel@nongnu.org; Wed, 15 Feb 2012 08:58:51 -0500 Received: from mx1.redhat.com ([209.132.183.28]:63956) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RxfNd-0006lB-AZ for qemu-devel@nongnu.org; Wed, 15 Feb 2012 08:58:45 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q1FDwZ6x013087 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 15 Feb 2012 08:58:35 -0500 Message-ID: <4F3BBA53.5050305@redhat.com> Date: Wed, 15 Feb 2012 15:59:47 +0200 From: Yonit Halperin MIME-Version: 1.0 References: <1329311466-20344-1-git-send-email-kraxel@redhat.com> <4F3BB1A0.7050909@redhat.com> <4F3BB4F7.3030906@redhat.com> In-Reply-To: <4F3BB4F7.3030906@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qxl: don't render stuff when the vm is stopped. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org On 02/15/2012 03:36 PM, Gerd Hoffmann wrote: > On 02/15/12 14:22, Yonit Halperin wrote: >> Hi, >> On 02/15/2012 03:11 PM, Gerd Hoffmann wrote: >>> This patch fixes the local qxl renderer to not kick spice-server in case >>> the vm is stopped. First it is pointless because we render evevything >>> when the vm is stopped. Thus there is nothing to render anyway because >>> a stopped guest can hardly queue more commands. >> hmm...When the vm is stopped we render only commands that we already >> read. We don't do more reading from the command ring. > > Ah, ok. > >> So there may be >> other pending commands that were not rendered. That is why I >> suggested allowing rendering when the vm is stopped. But >> not allowing it during loading the vm during migration. > > I'd prefer to keep things simple: let the spice worker run when the > guest runs, no exceptions. > > We may leave some unrendered commands in the ring then. Ok. Is that a > problem for some reason? Note that the guest may have more commands > queued which spice-server simply doesn't see yet due to the ring being > full. If we stop the guest the wrong moment we can end up with a > half-done screen update operation no matter what. Ok. Then ack after correcting the patch comment. Thanks, Yonit. > > cheers, > Gerd >