From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:38667) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RxiWX-0000xy-OD for qemu-devel@nongnu.org; Wed, 15 Feb 2012 12:20:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RxiWK-0005IR-18 for qemu-devel@nongnu.org; Wed, 15 Feb 2012 12:20:06 -0500 Received: from relay1.mentorg.com ([192.94.38.131]:38656) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RxiWJ-0005I7-T1 for qemu-devel@nongnu.org; Wed, 15 Feb 2012 12:19:55 -0500 Message-ID: <4F3BE937.7070408@codesourcery.com> Date: Wed, 15 Feb 2012 11:19:51 -0600 From: Meador Inge MIME-Version: 1.0 References: <1329324093-6581-1-git-send-email-meadori@codesourcery.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v1] ./configure: use -lole32 when building with mingw32 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org On 02/15/2012 10:49 AM, Peter Maydell wrote: > On 15 February 2012 16:41, Meador Inge wrote: >> glib calls 'CoTaskMemFree' which is defined by ole32.dll. >> Therefore when building with mingw32 -lole32 should be in >> 'LIBS'. > > Not that I'm objecting to the patch, but isn't this technically > a bug in the pkg-config for glib with mingw32 that we're working > around? Yup, the issue is fixed in recent versions of glib: http://git.gnome.org/browse/glib/commit/?id=b79eae5c197aeec8d57f39c0f7bf5d5114068bea http://git.gnome.org/browse/glib/commit/?id=5377c0de0108d292ea3e23fa6d90410f9ac9fa00 I am OK with backporting the glib fix for mingw32 builds. Sorry for the noise. -- Meador Inge CodeSourcery / Mentor Embedded http://www.mentor.com/embedded-software