From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:37674)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1RxyOV-0000AX-QF
	for qemu-devel@nongnu.org; Thu, 16 Feb 2012 05:17:01 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1RxyOQ-0003GW-0a
	for qemu-devel@nongnu.org; Thu, 16 Feb 2012 05:16:55 -0500
Received: from thoth.sbs.de ([192.35.17.2]:31393)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1RxyOP-0003G9-ML
	for qemu-devel@nongnu.org; Thu, 16 Feb 2012 05:16:49 -0500
Message-ID: <4F3CD78D.3030604@siemens.com>
Date: Thu, 16 Feb 2012 11:16:45 +0100
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <1329347774-23262-1-git-send-email-imammedo@redhat.com>
	<1329347774-23262-8-git-send-email-imammedo@redhat.com>
	<4F3C4146.1000905@codemonkey.ws>
In-Reply-To: <4F3C4146.1000905@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 7/7] Implement cpu hot-add using device_add
 monitor command
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Igor Mammedov <imammedo@redhat.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "gleb@redhat.com" <gleb@redhat.com>

On 2012-02-16 00:35, Anthony Liguori wrote:
> On 02/15/2012 05:16 PM, Igor Mammedov wrote:
>> Adds ability to hot-add cpus if guest was started with options
>>      -smp X,maxcpus=Y
>> where X<  Y.
>> For simplicity sake this implementation doesn't allow to add specific
>> cpu but rather it adds the next not yet plugged cpu.
>>
>> For adding cpu just execute following command in monitor:
>>      device_add cpu-pc
>> If guest was started with a specific cpu model, then add option model
>> to cmonitor command. for example:
>>      device_add cpu-pc,model="host"
>>
>> Signed-off-by: Igor Mammedov<imammedo@redhat.com>
> 
> I don't see how the code matches this description, but unless you've got 
> qdev-ification patches in the earlier ones (haven't made the list yet), 
> device_add is not the right place for this.
> 
> There's no such thing as "cpu-pc" either.  You should start with a cpu_add command.

The proper ordering is first qdev'ify x86 CPUs, then use device_add. No
new throw-away commands, please.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux