From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:34181) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ry0fW-0005EJ-Vc for qemu-devel@nongnu.org; Thu, 16 Feb 2012 07:42:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ry0fN-0004OT-GR for qemu-devel@nongnu.org; Thu, 16 Feb 2012 07:42:38 -0500 Received: from mail-pz0-f45.google.com ([209.85.210.45]:46645) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ry0fN-0004OL-A4 for qemu-devel@nongnu.org; Thu, 16 Feb 2012 07:42:29 -0500 Received: by dadp14 with SMTP id p14so2461789dad.4 for ; Thu, 16 Feb 2012 04:42:27 -0800 (PST) Message-ID: <4F3CF9AE.5020701@codemonkey.ws> Date: Thu, 16 Feb 2012 06:42:22 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <1329347774-23262-1-git-send-email-imammedo@redhat.com> <1329347774-23262-2-git-send-email-imammedo@redhat.com> <4F3CE7A5.30600@siemens.com> In-Reply-To: <4F3CE7A5.30600@siemens.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/7] Introduce a new bus "ICC" to connect APIC List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Igor Mammedov , "qemu-devel@nongnu.org" , "gleb@redhat.com" On 02/16/2012 05:25 AM, Jan Kiszka wrote: > On 2012-02-16 00:16, Igor Mammedov wrote: >> Introduce a new structure CPUS as the controller of ICC (INTERRUPT >> CONTROLLER COMMUNICATIONS), and new bus "ICC" to hold APIC,instead >> of sysbus. So we can support APIC hot-plug feature. >> >> This is repost of original patch for qemu-kvm rebased on current qemu: >> http://lists.nongnu.org/archive/html/qemu-devel/2011-11/msg01478.html >> All credits to Liu Ping Fan for writing it. >> >> V2 changes: >> - cpusockets_init: cpu_sockets is not yet initialized, use cpus that >> we got as input param instead for qbus_create, this makes cpus >> apics visible in "info qtree" monitor command >> - fix format error spotted by Jan and missed by checkpatch >> - cpu_has_apic_feature: return bool instead of int >> > > This patch surely no longer applies. And the ICC requires QOM conversion. Also, post-QOM, I don't think having an ICC bus makes a whole lot of sense. The LAPIC can be made a child of the CPU device with a bidirectional link. I would simply create a fixed set of CPU links<> hung off of /devices somewhere and use that as the hotplug mechanism. This matches well the way we model this to the guest (we expose a fixed number of pluggable sockets). Regards, Anthony Liguori > > Jan >