From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:40764) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ry0sE-0003hQ-Rr for qemu-devel@nongnu.org; Thu, 16 Feb 2012 07:55:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ry0s5-00072I-50 for qemu-devel@nongnu.org; Thu, 16 Feb 2012 07:55:46 -0500 Received: from david.siemens.de ([192.35.17.14]:27603) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ry0s4-00071j-MV for qemu-devel@nongnu.org; Thu, 16 Feb 2012 07:55:37 -0500 Message-ID: <4F3CFCC5.5010308@siemens.com> Date: Thu, 16 Feb 2012 13:55:33 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <20120216091251.GD19771@redhat.com> In-Reply-To: <20120216091251.GD19771@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH uq/master] Synchronize cpu state with kernel before poking into registers. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gleb Natapov Cc: mtosatti@redhat.com, avi@redhat.com, kvm@vger.kernel.org, qemu-devel On 2012-02-16 10:12, Gleb Natapov wrote: > Call to kvm_cpu_synchronize_state() is missing. kvm_arch_stop_on_emulation_error may > look at outdated registers here. > > Signed-off-by: Gleb Natapov > diff --git a/target-i386/kvm.c b/target-i386/kvm.c > index 7079e87..51d0ae7 100644 > --- a/target-i386/kvm.c > +++ b/target-i386/kvm.c > @@ -2020,6 +2020,7 @@ int kvm_arch_handle_exit(CPUState *env, struct kvm_run *run) > > bool kvm_arch_stop_on_emulation_error(CPUState *env) > { > + kvm_cpu_synchronize_state(env); > return !(env->cr[0] & CR0_PE_MASK) || > ((env->segs[R_CS].selector & 3) != 3); > } Reviewed-by: Jan Kiszka -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux