From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:56840) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ry3H8-0006Gi-9G for qemu-devel@nongnu.org; Thu, 16 Feb 2012 10:29:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ry3H3-0002XY-NP for qemu-devel@nongnu.org; Thu, 16 Feb 2012 10:29:38 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38520) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ry3H3-0002XM-GT for qemu-devel@nongnu.org; Thu, 16 Feb 2012 10:29:33 -0500 Message-ID: <4F3D20D8.9000700@redhat.com> Date: Thu, 16 Feb 2012 17:29:28 +0200 From: Avi Kivity MIME-Version: 1.0 References: <286b8c6486f3b021ee21ec16960f5ffd4770225b.1329232393.git.jan.kiszka@siemens.com> In-Reply-To: <286b8c6486f3b021ee21ec16960f5ffd4770225b.1329232393.git.jan.kiszka@siemens.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 6/9] kvmvapic: Introduce TPR access optimization for Windows guests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Anthony Liguori , Gleb Natapov , kvm@vger.kernel.org, Marcelo Tosatti , qemu-devel , Blue Swirl On 02/14/2012 05:13 PM, Jan Kiszka wrote: > This enables acceleration for MMIO-based TPR registers accesses of > 32-bit Windows guest systems. It is mostly useful with KVM enabled, > either on older Intel CPUs (without flexpriority feature, can also be > manually disabled for testing) or any current AMD processor. > > The approach introduced here is derived from the original version of > qemu-kvm. It was refactored, documented, and extended by support for > user space APIC emulation, both with and without KVM acceleration. The > VMState format was kept compatible, so was the ABI to the option ROM > that implements the guest-side para-virtualized driver service. This > enables seamless migration from qemu-kvm to upstream or, one day, > between KVM and TCG mode. > > > +printf("patch @%lx\n", (long)ip); Debug code -- error compiling committee.c: too many arguments to function