qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Barabash <alexander_barabash@mentor.com>
To: qemu-trivial@nongnu.org, qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] [PATCH] [TRIVIAL] Removed unused arm_sysctl_init().
Date: Thu, 16 Feb 2012 19:37:54 +0200	[thread overview]
Message-ID: <4F3D3EF2.4090503@mentor.com> (raw)


     Removed unused arm_sysctl_init().
     Renamed arm_sysctl_init1() into arm_sysctl_init().

     Signed-off-by: Alexander Barabash <alexander_barabash@mentor.com>

diff --git a/hw/arm_sysctl.c b/hw/arm_sysctl.c
index 149c639..5f1237b 100644
--- a/hw/arm_sysctl.c
+++ b/hw/arm_sysctl.c
@@ -378,7 +378,7 @@ static void arm_sysctl_gpio_set(void *opaque, int 
line, int level)
      }
  }

-static int arm_sysctl_init1(SysBusDevice *dev)
+static int arm_sysctl_init(SysBusDevice *dev)
  {
      arm_sysctl_state *s = FROM_SYSBUS(arm_sysctl_state, dev);

@@ -389,18 +389,6 @@ static int arm_sysctl_init1(SysBusDevice *dev)
      return 0;
  }

-/* Legacy helper function.  */
-void arm_sysctl_init(uint32_t base, uint32_t sys_id, uint32_t proc_id)
-{
-    DeviceState *dev;
-
-    dev = qdev_create(NULL, "realview_sysctl");
-    qdev_prop_set_uint32(dev, "sys_id", sys_id);
-    qdev_init_nofail(dev);
-    qdev_prop_set_uint32(dev, "proc_id", proc_id);
-    sysbus_mmio_map(sysbus_from_qdev(dev), 0, base);
-}
-
  static Property arm_sysctl_properties[] = {
      DEFINE_PROP_UINT32("sys_id", arm_sysctl_state, sys_id, 0),
      DEFINE_PROP_UINT32("proc_id", arm_sysctl_state, proc_id, 0),
@@ -412,7 +400,7 @@ static void arm_sysctl_class_init(ObjectClass 
*klass, void *data)
      DeviceClass *dc = DEVICE_CLASS(klass);
      SysBusDeviceClass *k = SYS_BUS_DEVICE_CLASS(klass);

-    k->init = arm_sysctl_init1;
+    k->init = arm_sysctl_init;
      dc->reset = arm_sysctl_reset;
      dc->vmsd = &vmstate_arm_sysctl;
      dc->props = arm_sysctl_properties;
diff --git a/hw/primecell.h b/hw/primecell.h
index ded0446..7337c3b 100644
--- a/hw/primecell.h
+++ b/hw/primecell.h
@@ -5,9 +5,6 @@
  /* Also includes some devices that are currently only used by the
     ARM boards.  */

-/* arm_sysctl.c */
-void arm_sysctl_init(uint32_t base, uint32_t sys_id, uint32_t proc_id);
-
  /* arm_sysctl GPIO lines */
  #define ARM_SYSCTL_GPIO_MMC_WPROT 0
  #define ARM_SYSCTL_GPIO_MMC_CARDIN 1

             reply	other threads:[~2012-02-16 17:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-16 17:37 Alexander Barabash [this message]
2012-02-16 18:18 ` [Qemu-devel] [PATCH] [TRIVIAL] Removed unused arm_sysctl_init() Peter Maydell
2012-02-16 18:22   ` Peter Maydell
2012-02-16 18:18 ` Andreas Färber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F3D3EF2.4090503@mentor.com \
    --to=alexander_barabash@mentor.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).