From: Avi Kivity <avi@redhat.com>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: [Qemu-devel] Minor regression with kvm ioapic, gsi >= 16
Date: Thu, 16 Feb 2012 20:55:31 +0200 [thread overview]
Message-ID: <4F3D5123.1020209@redhat.com> (raw)
kvm-unit-tests.git x86/apic.flat is failing ioapic tests with
qemu-system-x86_64 -vnc :99 -device testdev,chardev=x -chardev null,id=x
-smp 2 -kernel ./x86/apic.flat -serial stdio
...
ioapic interrupt: FAIL
ioapic simultaneous interrupt: FAIL
This happens because the test is invoking gsi 16, which is handled by
the non-kvm ioapic instead of the kvm ioapic.
Introduced by
commit c3388c9bd8d4f4fd841b521feed20993185d9be4
Author: Jan Kiszka <jan.kiszka@siemens.com>
Date: Mon Feb 6 12:20:53 2012 +0100
qemu-kvm: Fix GSI handling with in-kernel irqchip
Interrupt routing with in-kernel irqchip was always a mess. Now this
increased after latest upstream merge: we started to call ioapic_set_irq
also for kernel-handled interrupts.
Reduce this mess again by using the upstream kvm_piix3_gsi_handler. It
is aware of the PIIX3-specific routing in KVM mode and won't call into
the user space APIC model (as we do not raise IRQs >= ISA_NUM_IRQS with
the PIIX3).
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
The obvious fix would be to start using upstream's kvm-ioapic, but you
haven't, why?
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
next reply other threads:[~2012-02-16 18:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-16 18:55 Avi Kivity [this message]
2012-02-16 20:04 ` [Qemu-devel] Minor regression with kvm ioapic, gsi >= 16 Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F3D5123.1020209@redhat.com \
--to=avi@redhat.com \
--cc=jan.kiszka@web.de \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).