From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:34149) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ry6UY-0007bU-8X for qemu-devel@nongnu.org; Thu, 16 Feb 2012 13:55:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ry6US-0002Yi-85 for qemu-devel@nongnu.org; Thu, 16 Feb 2012 13:55:42 -0500 Received: from mx1.redhat.com ([209.132.183.28]:62669) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ry6US-0002Ya-1P for qemu-devel@nongnu.org; Thu, 16 Feb 2012 13:55:36 -0500 Message-ID: <4F3D5123.1020209@redhat.com> Date: Thu, 16 Feb 2012 20:55:31 +0200 From: Avi Kivity MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Minor regression with kvm ioapic, gsi >= 16 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Marcelo Tosatti , "qemu-devel@nongnu.org" kvm-unit-tests.git x86/apic.flat is failing ioapic tests with qemu-system-x86_64 -vnc :99 -device testdev,chardev=x -chardev null,id=x -smp 2 -kernel ./x86/apic.flat -serial stdio ... ioapic interrupt: FAIL ioapic simultaneous interrupt: FAIL This happens because the test is invoking gsi 16, which is handled by the non-kvm ioapic instead of the kvm ioapic. Introduced by commit c3388c9bd8d4f4fd841b521feed20993185d9be4 Author: Jan Kiszka Date: Mon Feb 6 12:20:53 2012 +0100 qemu-kvm: Fix GSI handling with in-kernel irqchip Interrupt routing with in-kernel irqchip was always a mess. Now this increased after latest upstream merge: we started to call ioapic_set_irq also for kernel-handled interrupts. Reduce this mess again by using the upstream kvm_piix3_gsi_handler. It is aware of the PIIX3-specific routing in KVM mode and won't call into the user space APIC model (as we do not raise IRQs >= ISA_NUM_IRQS with the PIIX3). Signed-off-by: Jan Kiszka Signed-off-by: Marcelo Tosatti The obvious fix would be to start using upstream's kvm-ioapic, but you haven't, why? -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.