From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:44323)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1RyJEQ-00006F-Op
	for qemu-devel@nongnu.org; Fri, 17 Feb 2012 03:32:00 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1RyJEL-00005d-5L
	for qemu-devel@nongnu.org; Fri, 17 Feb 2012 03:31:54 -0500
Received: from mx1.redhat.com ([209.132.183.28]:52040)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1RyJEK-00005U-Uq
	for qemu-devel@nongnu.org; Fri, 17 Feb 2012 03:31:49 -0500
Message-ID: <4F3E106F.8060102@redhat.com>
Date: Fri, 17 Feb 2012 09:31:43 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1327061206-9404-1-git-send-email-pbonzini@redhat.com>
	<1327061206-9404-3-git-send-email-pbonzini@redhat.com>
	<CAOq732JfDJt2Ww7-NYHFVytO7atDG1yjkOcCkr4dfvkFVRjaSw@mail.gmail.com>
	<4F3E0A47.10001@redhat.com>
	<CAOq732LZU10Lk_dw1Hwz83Q+e2qsFM9NWEQPiASfKjcJqPXT2A@mail.gmail.com>
In-Reply-To: <CAOq732LZU10Lk_dw1Hwz83Q+e2qsFM9NWEQPiASfKjcJqPXT2A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/4] arm: switch real-time clocks to
	rtc_clock
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: andrzej zaborowski <balrogg@gmail.com>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org

On 02/17/2012 09:24 AM, andrzej zaborowski wrote:
>> > Ok, then I think it's better to switch that one to vm_clock (so that you
>> > could use it as a deterministic debugging aid with -icount, for
>> > example).  What do you think?
> I was thinking about potential visual effects.

vm_clock is the same as rt_clock as long as: 1) you don't use -icount;
2) you don't stop the VM.

Not pulsing the LED when the VM is stopped seems okay, so I think
switching from rt_clock to vm_clock is the right thing to do.

> But perhaps you were
> right with the first approach, i.e. debugging -> deterministic (which
> in this case would ideally also use the frequency derived from the
> system clock passed to omap_lpg_init), normal work -> realtime.

You should get this from -icount if you just use vm_clock.

The overall series doesn't apply anymore, I'll split omap_lpg into its
own patch and resend.

Paolo