From: Paolo Bonzini <pbonzini@redhat.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
eblake@redhat.com, Markus Armbruster <armbru@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 4/4] qmp: add BLOCK_MEDIUM_EJECT event
Date: Fri, 17 Feb 2012 11:32:48 +0100 [thread overview]
Message-ID: <4F3E2CD0.50506@redhat.com> (raw)
In-Reply-To: <20120216121015.7ccaa462@doriath.home>
On 02/16/2012 03:10 PM, Luiz Capitulino wrote:
> We have two external entities: the guest and the mngt app. It seems to me that
> the guest is seeing each step at a time.
The guest is seeing each step separately, but that is managed by the
device model (which sends two separate error codes: a NOT READY for
opening the tray, and a UNIT ATTENTION for closing the tray and changing
medium) rather than by the monitor.
> Btw, wrt fixing the internal model, I could do it in a different series, But I don't
> know exactly how to. Maybe bdrv_dev_change_media_cb() should be broken into
> multiple operations...
change_media_cb is really a move_tray_cb and we could rename it.
Calling it twice from the change command should work.
Paolo
next prev parent reply other threads:[~2012-02-17 10:33 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-15 18:42 [Qemu-devel] [PATCH v2 0/4]: QMP: add BLOCK_MEDIUM_EJECT event Luiz Capitulino
2012-02-15 18:42 ` [Qemu-devel] [PATCH 1/4] block: Rename bdrv_mon_event() & BlockMonEventAction Luiz Capitulino
2012-02-15 18:42 ` [Qemu-devel] [PATCH 2/4] block: bdrv_eject(): Make eject_flag a real bool Luiz Capitulino
2012-02-15 18:42 ` [Qemu-devel] [PATCH 3/4] block: bdrv_eject(): Add tray_changed parameter Luiz Capitulino
2012-02-15 18:42 ` [Qemu-devel] [PATCH 4/4] qmp: add BLOCK_MEDIUM_EJECT event Luiz Capitulino
2012-02-16 9:25 ` Markus Armbruster
2012-02-16 13:14 ` Luiz Capitulino
2012-02-16 13:19 ` Luiz Capitulino
2012-02-16 13:31 ` Kevin Wolf
2012-02-16 14:10 ` Luiz Capitulino
2012-02-17 10:32 ` Paolo Bonzini [this message]
2012-02-17 11:03 ` Kevin Wolf
2012-02-17 11:48 ` Markus Armbruster
2012-02-17 12:12 ` Kevin Wolf
2012-02-17 12:43 ` Markus Armbruster
2012-02-16 18:30 ` Markus Armbruster
2012-02-16 19:08 ` Luiz Capitulino
2012-02-17 9:53 ` Kevin Wolf
2012-02-17 10:48 ` Paolo Bonzini
2012-02-17 11:50 ` Markus Armbruster
2012-02-17 11:44 ` Markus Armbruster
2012-02-17 11:56 ` Luiz Capitulino
2012-02-17 10:45 ` Paolo Bonzini
2012-02-17 11:57 ` Markus Armbruster
2012-02-17 10:49 ` [Qemu-devel] [PATCH v2 0/4]: QMP: " Paolo Bonzini
2012-02-17 11:58 ` Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F3E2CD0.50506@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).