From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:33520) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RyL7a-0001Xe-6A for qemu-devel@nongnu.org; Fri, 17 Feb 2012 05:33:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RyL7U-0004FV-Gk for qemu-devel@nongnu.org; Fri, 17 Feb 2012 05:32:58 -0500 Received: from mx1.redhat.com ([209.132.183.28]:19825) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RyL7U-0004FN-9a for qemu-devel@nongnu.org; Fri, 17 Feb 2012 05:32:52 -0500 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q1HAWp0Q020633 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 17 Feb 2012 05:32:51 -0500 Message-ID: <4F3E2CD0.50506@redhat.com> Date: Fri, 17 Feb 2012 11:32:48 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1329331347-11232-1-git-send-email-lcapitulino@redhat.com> <1329331347-11232-5-git-send-email-lcapitulino@redhat.com> <20120216111447.2160fa63@doriath.home> <4F3D054C.9020603@redhat.com> <20120216121015.7ccaa462@doriath.home> In-Reply-To: <20120216121015.7ccaa462@doriath.home> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/4] qmp: add BLOCK_MEDIUM_EJECT event List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: Kevin Wolf , eblake@redhat.com, Markus Armbruster , qemu-devel@nongnu.org On 02/16/2012 03:10 PM, Luiz Capitulino wrote: > We have two external entities: the guest and the mngt app. It seems to me that > the guest is seeing each step at a time. The guest is seeing each step separately, but that is managed by the device model (which sends two separate error codes: a NOT READY for opening the tray, and a UNIT ATTENTION for closing the tray and changing medium) rather than by the monitor. > Btw, wrt fixing the internal model, I could do it in a different series, But I don't > know exactly how to. Maybe bdrv_dev_change_media_cb() should be broken into > multiple operations... change_media_cb is really a move_tray_cb and we could rename it. Calling it twice from the change command should work. Paolo