qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, eblake@redhat.com,
	Markus Armbruster <armbru@redhat.com>,
	Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 4/4] qmp: add BLOCK_MEDIUM_EJECT event
Date: Fri, 17 Feb 2012 11:48:09 +0100	[thread overview]
Message-ID: <4F3E3069.7060109@redhat.com> (raw)
In-Reply-To: <4F3E239C.6050402@redhat.com>

On 02/17/2012 10:53 AM, Kevin Wolf wrote:
> > Note: device models call bdrv_eject() whether the state changed or not.
> > The only use for that I can see is syncing a wayward physical tray to
> > the virtual one.  Shouldn't be necessary with Paolo's recent work,
> > should it?
> 
> The one case that I'm unsure about is migration. I thought we sync the
> physical tray with the virtual one then (or at least we discussed it),
> but I don't really know what we do today, or even what the right thing
> to do is in some cases.

Migration with passthrough doesn't make sense.  The only way it could
work (untested) is if the destination connected via iSCSI to the
source's CD-ROM.  In which case the physical and virtual tray would be
synced already.

Paolo

  reply	other threads:[~2012-02-17 10:48 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-15 18:42 [Qemu-devel] [PATCH v2 0/4]: QMP: add BLOCK_MEDIUM_EJECT event Luiz Capitulino
2012-02-15 18:42 ` [Qemu-devel] [PATCH 1/4] block: Rename bdrv_mon_event() & BlockMonEventAction Luiz Capitulino
2012-02-15 18:42 ` [Qemu-devel] [PATCH 2/4] block: bdrv_eject(): Make eject_flag a real bool Luiz Capitulino
2012-02-15 18:42 ` [Qemu-devel] [PATCH 3/4] block: bdrv_eject(): Add tray_changed parameter Luiz Capitulino
2012-02-15 18:42 ` [Qemu-devel] [PATCH 4/4] qmp: add BLOCK_MEDIUM_EJECT event Luiz Capitulino
2012-02-16  9:25   ` Markus Armbruster
2012-02-16 13:14     ` Luiz Capitulino
2012-02-16 13:19       ` Luiz Capitulino
2012-02-16 13:31       ` Kevin Wolf
2012-02-16 14:10         ` Luiz Capitulino
2012-02-17 10:32           ` Paolo Bonzini
2012-02-17 11:03             ` Kevin Wolf
2012-02-17 11:48               ` Markus Armbruster
2012-02-17 12:12                 ` Kevin Wolf
2012-02-17 12:43                   ` Markus Armbruster
2012-02-16 18:30         ` Markus Armbruster
2012-02-16 19:08           ` Luiz Capitulino
2012-02-17  9:53           ` Kevin Wolf
2012-02-17 10:48             ` Paolo Bonzini [this message]
2012-02-17 11:50               ` Markus Armbruster
2012-02-17 11:44             ` Markus Armbruster
2012-02-17 11:56               ` Luiz Capitulino
2012-02-17 10:45           ` Paolo Bonzini
2012-02-17 11:57             ` Markus Armbruster
2012-02-17 10:49 ` [Qemu-devel] [PATCH v2 0/4]: QMP: " Paolo Bonzini
2012-02-17 11:58   ` Luiz Capitulino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F3E3069.7060109@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=armbru@redhat.com \
    --cc=eblake@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).