From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:37867)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1RyLMR-0005n3-2Z
	for qemu-devel@nongnu.org; Fri, 17 Feb 2012 05:48:19 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1RyLML-0007Rt-Ae
	for qemu-devel@nongnu.org; Fri, 17 Feb 2012 05:48:18 -0500
Received: from mx1.redhat.com ([209.132.183.28]:35934)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1RyLML-0007Rl-2i
	for qemu-devel@nongnu.org; Fri, 17 Feb 2012 05:48:13 -0500
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q1HAmCH0025327
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 17 Feb 2012 05:48:12 -0500
Message-ID: <4F3E3069.7060109@redhat.com>
Date: Fri, 17 Feb 2012 11:48:09 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1329331347-11232-1-git-send-email-lcapitulino@redhat.com>
	<1329331347-11232-5-git-send-email-lcapitulino@redhat.com>
	<m3d39fp1t4.fsf@blackfin.pond.sub.org>
	<20120216111447.2160fa63@doriath.home>
	<4F3D054C.9020603@redhat.com>
	<m3zkcivdfu.fsf@blackfin.pond.sub.org>
	<4F3E239C.6050402@redhat.com>
In-Reply-To: <4F3E239C.6050402@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 4/4] qmp: add BLOCK_MEDIUM_EJECT event
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, eblake@redhat.com, Markus Armbruster <armbru@redhat.com>, Luiz Capitulino <lcapitulino@redhat.com>

On 02/17/2012 10:53 AM, Kevin Wolf wrote:
> > Note: device models call bdrv_eject() whether the state changed or not.
> > The only use for that I can see is syncing a wayward physical tray to
> > the virtual one.  Shouldn't be necessary with Paolo's recent work,
> > should it?
> 
> The one case that I'm unsure about is migration. I thought we sync the
> physical tray with the virtual one then (or at least we discussed it),
> but I don't really know what we do today, or even what the right thing
> to do is in some cases.

Migration with passthrough doesn't make sense.  The only way it could
work (untested) is if the destination connected via iSCSI to the
source's CD-ROM.  In which case the physical and virtual tray would be
synced already.

Paolo