From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:38071)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1RyNp9-0003aq-Aa
	for qemu-devel@nongnu.org; Fri, 17 Feb 2012 08:26:16 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1RyNp3-0005Ob-Ir
	for qemu-devel@nongnu.org; Fri, 17 Feb 2012 08:26:07 -0500
Received: from mx1.redhat.com ([209.132.183.28]:27364)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1RyNp3-0005OX-40
	for qemu-devel@nongnu.org; Fri, 17 Feb 2012 08:26:01 -0500
Message-ID: <4F3E5564.7040406@redhat.com>
Date: Fri, 17 Feb 2012 14:25:56 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <cover.1329124507.git.mst@redhat.com>
	<f9b630bb6c67f0facf29e42277ad7d991e660b3c.1329124507.git.mst@redhat.com>
In-Reply-To: <f9b630bb6c67f0facf29e42277ad7d991e660b3c.1329124507.git.mst@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCHv2-RFC 2/2] pci: add standard bridge device
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Isaku Yamahata <yamahata@valinux.co.jp>, qemu-devel@nongnu.org, kvm@vger.kernel.org, Avi Kivity <avi@redhat.com>

  Hi,

> +    /* If we don't specify the name, the bus will be addressed as <id>.0, where
> +     * id is the parent id.  But it seems more natural to address the bus using
> +     * the parent device name. */
> +    if (dev->qdev.id && *dev->qdev.id) {
> +        br->bus_name = dev->qdev.id;
> +    }

That makes the bridge behave different than everybody else.
Not a good idea IMHO.

cheers,
  Gerd