From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:47654) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RyOrf-0001P8-KC for qemu-devel@nongnu.org; Fri, 17 Feb 2012 09:32:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RyOrZ-0001Mu-O8 for qemu-devel@nongnu.org; Fri, 17 Feb 2012 09:32:47 -0500 Received: from e36.co.us.ibm.com ([32.97.110.154]:55323) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RyOrZ-0001Md-Gb for qemu-devel@nongnu.org; Fri, 17 Feb 2012 09:32:41 -0500 Received: from /spool/local by e36.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 17 Feb 2012 07:32:38 -0700 Received: from d03relay01.boulder.ibm.com (d03relay01.boulder.ibm.com [9.17.195.226]) by d03dlp02.boulder.ibm.com (Postfix) with ESMTP id 0592F3E40049 for ; Fri, 17 Feb 2012 07:32:34 -0700 (MST) Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by d03relay01.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q1HEWLat144476 for ; Fri, 17 Feb 2012 07:32:22 -0700 Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1]) by d03av01.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q1HEVKN5029204 for ; Fri, 17 Feb 2012 07:31:20 -0700 Message-ID: <4F3E64B6.5020309@us.ibm.com> Date: Fri, 17 Feb 2012 08:31:18 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <1328799563-18932-1-git-send-email-afaerber@suse.de> <4F349415.2000507@samsung.com> <4F355845.5040902@us.ibm.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] checkpatch: Don't WARN about missing spaces in audio files List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-devel@nongnu.org, Paolo Bonzini , Stefan Hajnoczi , Evgeny Voevodin , Alexander Graf On 02/11/2012 03:44 AM, Blue Swirl wrote: > On Fri, Feb 10, 2012 at 17:47, Anthony Liguori wrote: >> On 02/09/2012 10:02 PM, malc wrote: >>> >>> On Fri, 10 Feb 2012, Evgeny Voevodin wrote: >>> >>>> On 02/09/2012 06:59 PM, Andreas F?rber wrote: >>>>> >>>>> Disable warnings for spaces before opening parenthesis in >>>>> hw/{ac97,adlib,cs4231a,es1370,gus,sb16}.c. >>>> >>>> >>>> Why audio files are such a special thing? >>> >>> >>> Because they are consistently formatted the way they are. >> >> >> I personally hate the QEMU Coding Style I dislike inconsistency more than >> any particular style. > > I dislike unclear rules more than inconsistency or coding styles. > >> So I'm with malc here. I'd be opposed to introducing a new file that >> deviated from Coding Style but for the ones that already do, I see no reason >> to convert them all at once or make the code deviate from the style it's >> already using. > > I'd make a rule, specify the level of importance and try to stick to > it. I would not oppose global reformatting to GNU style even (which I > hate) if that would be the rule. I really hate having these discussions. I would almost rather we just pay the one-time cost of re-indenting so we can stop debating about this. For folks that feel strongly about this, please submit the following: An indent command that takes the tree to CODING_STYLE along with a diffstat of the end result. Depending on how bad the diffstat is, we can consider doing this and ending this set of arguments once and for all. Regards, Anthony Liguori > I don't like laissez faire, but if > that is the rule then fine. > >> >>> >>>> Isn't it be better to revert a patch that introduced checkpatch.pl >>>> errors? >>> >>> >>> No. >> >> >> Regards, >> >> Anthony Liguori >> >> >>> >> > >