From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:51216) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RyPiv-0006gM-Db for qemu-devel@nongnu.org; Fri, 17 Feb 2012 10:27:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RyPis-0003vQ-Li for qemu-devel@nongnu.org; Fri, 17 Feb 2012 10:27:49 -0500 Received: from e9.ny.us.ibm.com ([32.97.182.139]:56871) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RyPis-0003v6-Ev for qemu-devel@nongnu.org; Fri, 17 Feb 2012 10:27:46 -0500 Received: from /spool/local by e9.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 17 Feb 2012 10:27:43 -0500 Received: from d01relay03.pok.ibm.com (d01relay03.pok.ibm.com [9.56.227.235]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id 82C806E807C for ; Fri, 17 Feb 2012 10:27:30 -0500 (EST) Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d01relay03.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q1HFRTkW282586 for ; Fri, 17 Feb 2012 10:27:29 -0500 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q1HFRHBk019007 for ; Fri, 17 Feb 2012 08:27:17 -0700 Message-ID: <4F3E71BD.6030506@us.ibm.com> Date: Fri, 17 Feb 2012 09:26:53 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <1328799563-18932-1-git-send-email-afaerber@suse.de> <4F349415.2000507@samsung.com> <4F355845.5040902@us.ibm.com> <4F3E64B6.5020309@us.ibm.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] checkpatch: Don't WARN about missing spaces in audio files List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Stefan Hajnoczi , Evgeny Voevodin , Alexander Graf , qemu-devel@nongnu.org, Blue Swirl , Paolo Bonzini On 02/17/2012 08:55 AM, Markus Armbruster wrote: > Anthony Liguori writes: > >> I really hate having these discussions. I would almost rather we just >> pay the one-time cost of re-indenting so we can stop debating about >> this. >> >> For folks that feel strongly about this, please submit the following: >> >> An indent command that takes the tree to CODING_STYLE along with a >> diffstat of the end result. >> >> Depending on how bad the diffstat is, we can consider doing this and >> ending this set of arguments once and for all. > > The only justification for an idiosyncratic coding style I can buy is > minimizing reindentation of old code. Well this was what I was getting at in my previous comments. If we just need to reindent < 10 files with a few random changes here and there, then maybe that isn't so bad. But if we have to touch every single file in the tree in a significant way, then no way is it justified. > If we reindent anyway, reindent > to something that isn't specific to the QEMU island, please. I don't even want to consider something that touches every line of code. That's effectively creating a new source tree and losing the continuity of our SCM history. Regards, Anthony Liguori