From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:33538) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RyV8R-0005u3-PJ for qemu-devel@nongnu.org; Fri, 17 Feb 2012 16:14:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RyV8P-00058X-3m for qemu-devel@nongnu.org; Fri, 17 Feb 2012 16:14:31 -0500 Received: from smtp1-g21.free.fr ([212.27.42.1]:41343) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RyV8O-00056D-8f for qemu-devel@nongnu.org; Fri, 17 Feb 2012 16:14:29 -0500 Message-ID: <4F3EC32B.6060705@reactos.org> Date: Fri, 17 Feb 2012 22:14:19 +0100 From: =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= MIME-Version: 1.0 References: <1329506837-30084-1-git-send-email-hpoussin@reactos.org> <1329506837-30084-3-git-send-email-hpoussin@reactos.org> <4F3EC09E.2060603@suse.de> In-Reply-To: <4F3EC09E.2060603@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v4 2/3] jazz-led: convert to QOM List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Cc: Anthony Liguori , qemu-devel@nongnu.org Andreas F=C3=A4rber a =C3=A9crit : > Am 17.02.2012 20:27, schrieb Herv=C3=A9 Poussineau: >> Some simplifications in I/O functions are possible because >> Jazz LED only registers one byte of I/O. >> >> Signed-off-by: Herv=C3=A9 Poussineau >> --- >> hw/jazz_led.c | 159 +++++++++++++++++++++++++----------------------= --------- >> hw/mips.h | 3 - >> hw/mips_jazz.c | 2 +- >> 3 files changed, 71 insertions(+), 93 deletions(-) >> >> diff --git a/hw/jazz_led.c b/hw/jazz_led.c >> index 1af9268..5d8040b 100644 >> --- a/hw/jazz_led.c >> +++ b/hw/jazz_led.c >> @@ -1,7 +1,7 @@ >> /* >> * QEMU JAZZ LED emulator. >> * >> - * Copyright (c) 2007 Herv=C3=A9 Poussineau >> + * Copyright (c) 2007-2012 Herve Poussineau >=20 > Did you intentionally drop the accent from your name? Yes, because I had some problems on different locales/differents OSes.=20 Patches generated by "git send-email" were not clean. >> +static void jazz_led_register(void) >=20 > The convention recently introduced would be jazz_led_register_types. Will do if I have to respin. >=20 >> +{ >> + type_register_static(&jazz_led_info); >> +} >> + >> +type_init(jazz_led_register); >=20 > No semicolon necessary. Will do if I have to respin. >=20 > The ops change looks good, and we're still stuck with SysBus for a bit > so just these minor nits. Herv=C3=A9