From: Anthony Liguori <anthony@codemonkey.ws>
To: Stefan Weil <sw@weilnetz.de>
Cc: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>,
Markus Armbruster <armbru@redhat.com>,
Blue Swirl <blauwirbel@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] checkpatch: Don't WARN about missing spaces in audio files
Date: Sat, 18 Feb 2012 08:18:38 -0600 [thread overview]
Message-ID: <4F3FB33E.9060109@codemonkey.ws> (raw)
In-Reply-To: <4F3F83F6.6030903@weilnetz.de>
On 02/18/2012 04:56 AM, Stefan Weil wrote:
> Am 18.02.2012 10:13, schrieb Blue Swirl:
>> On Fri, Feb 17, 2012 at 15:26, Anthony Liguori <aliguori@us.ibm.com> wrote:
>>> Well this was what I was getting at in my previous comments. If we just
>>> need to reindent < 10 files with a few random changes here and there, then
>>> maybe that isn't so bad.
>>>
>>> But if we have to touch every single file in the tree in a significant way,
>>> then no way is it justified.
>>
>> One way to handle this is gradual reformatting, every time when code
>> is touched, only changes towards common CODING_STYLE are allowed.
>> Small, contained reformatting patches should be also allowed, for
>> example to adjust brace style in one file a time or to remove spaces
>> at the end of line.
>
> I'd appreciate it very much if we could remove spaces at line endings
> for all non binary files as soon as possible.
Why?
I really can't understand this. It's not visible so it does no harm.
Regards,
Anthony Liguori
next prev parent reply other threads:[~2012-02-18 14:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-09 14:59 [Qemu-devel] [PATCH] checkpatch: Don't WARN about missing spaces in audio files Andreas Färber
2012-02-09 15:03 ` Andreas Färber
2012-02-09 16:43 ` malc
2012-02-10 3:50 ` Evgeny Voevodin
2012-02-10 4:02 ` malc
2012-02-10 17:47 ` Anthony Liguori
2012-02-11 9:44 ` Blue Swirl
2012-02-17 14:31 ` Anthony Liguori
2012-02-17 14:55 ` Markus Armbruster
2012-02-17 15:26 ` Anthony Liguori
2012-02-18 9:13 ` Blue Swirl
2012-02-18 10:56 ` Stefan Weil
2012-02-18 14:18 ` Anthony Liguori [this message]
2012-02-18 14:34 ` Blue Swirl
2012-02-18 15:53 ` Andreas Färber
2012-02-18 16:47 ` Eric Blake
2012-02-18 8:56 ` Blue Swirl
2012-02-18 9:07 ` [Qemu-devel] [PATCH] astyle: Formatting rules for QEMU Stefan Weil
2012-02-18 10:10 ` Blue Swirl
2012-02-18 11:13 ` Stefan Weil
2012-02-11 9:37 ` [Qemu-devel] [PATCH] checkpatch: Don't WARN about missing spaces in audio files Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F3FB33E.9060109@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=agraf@suse.de \
--cc=armbru@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).