From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:37600)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Ryl7c-0004yf-0i
	for qemu-devel@nongnu.org; Sat, 18 Feb 2012 09:18:44 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Ryl7a-0004Qk-Vm
	for qemu-devel@nongnu.org; Sat, 18 Feb 2012 09:18:43 -0500
Received: from mail-tul01m020-f173.google.com ([209.85.214.173]:50421)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Ryl7a-0004Qf-RR
	for qemu-devel@nongnu.org; Sat, 18 Feb 2012 09:18:42 -0500
Received: by obbup16 with SMTP id up16so6267903obb.4
	for <qemu-devel@nongnu.org>; Sat, 18 Feb 2012 06:18:42 -0800 (PST)
Message-ID: <4F3FB33E.9060109@codemonkey.ws>
Date: Sat, 18 Feb 2012 08:18:38 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1328799563-18932-1-git-send-email-afaerber@suse.de>	<4F349415.2000507@samsung.com>	<alpine.LNX.2.00.1202100801170.4898@linmac>	<4F355845.5040902@us.ibm.com>	<CAAu8pHu9=0w8go3gpjvbEryLf_nMA-HNa=AtEuM231fMO=AC+g@mail.gmail.com>	<4F3E64B6.5020309@us.ibm.com>	<m3sji9jyqu.fsf@blackfin.pond.sub.org>	<4F3E71BD.6030506@us.ibm.com>	<CAAu8pHtP9Ef1GJ-nDZx_UuPzYUg+G2HdHfdUR7DwoDQtWip94A@mail.gmail.com>
	<4F3F83F6.6030903@weilnetz.de>
In-Reply-To: <4F3F83F6.6030903@weilnetz.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] checkpatch: Don't WARN about missing
 spaces in audio files
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <sw@weilnetz.de>
Cc: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>, Markus Armbruster <armbru@redhat.com>, Blue Swirl <blauwirbel@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>

On 02/18/2012 04:56 AM, Stefan Weil wrote:
> Am 18.02.2012 10:13, schrieb Blue Swirl:
>> On Fri, Feb 17, 2012 at 15:26, Anthony Liguori <aliguori@us.ibm.com> wrote:
>>> Well this was what I was getting at in my previous comments. If we just
>>> need to reindent < 10 files with a few random changes here and there, then
>>> maybe that isn't so bad.
>>>
>>> But if we have to touch every single file in the tree in a significant way,
>>> then no way is it justified.
>>
>> One way to handle this is gradual reformatting, every time when code
>> is touched, only changes towards common CODING_STYLE are allowed.
>> Small, contained reformatting patches should be also allowed, for
>> example to adjust brace style in one file a time or to remove spaces
>> at the end of line.
>
> I'd appreciate it very much if we could remove spaces at line endings
> for all non binary files as soon as possible.

Why?

I really can't understand this.  It's not visible so it does no harm.

Regards,

Anthony Liguori